Calum Chamberlain
Calum Chamberlain
You make an interesting point - I haven't played around with pandas much - do you have to put much work in to convert between catalog objects and dataframes?
This is a nice idea to cope with this, but frustratingly the lack of checks for short template lengths in other places can lead to some short traces being included...
Sadly no - I think that generating templates not of the length requested is a bug that should be fixed as well, but that still won't help with older templates,...
Kia Ora Darren, it looks like the failed tests were due to a failure to download the test data: all the failed tests that I saw in the log seem...
Ah, apologies, it looks like you need to remove your `~/.eqcorrscan` directory as well - the error at the start of the log: ```python shutil.Error: Destination path '/Users/darrentpk/.eqcorrscan/pytest.ini' already exists...
Thanks for that. That one fail is an annoying doc test fail comparing 1 to 1.0 so nothing to worry about.
I'm actually going to re-open this as a reminder to make the `test_eqcorrscan` script more resilient to failed downloads. It should: 1. Take command line args to allow re-downloading without...
Bumping to 0.5.0 as we need to get 0.4.3 out and I won't have time to make this improvement before then.
Thanks for those @d-chambers (also thanks for the book recommendation, I'm chewing my way through it, and almost every page has something of great interest!). At the moment, the function...
Ah, no, `_zero_pad_gaps` just works on the trace data... this would just encompass a pre-processing (filter and resample, not correlate) process... Does that make sense? The flow is something like:...