cboe icon indicating copy to clipboard operation
cboe copied to clipboard

Redo2-II

Open fosnola opened this issue 2 years ago • 2 comments

I just rebased redo2, so a new pull request.

Note: there were many conflicts to solve, I tried to solve them, but I don't guarantee anything...

fosnola avatar Feb 04 '23 14:02 fosnola

@CelticMinstrel Looking through the commit messages, I can't help but think there's some important stuff in here still to be pulled out. Possibly even direct fixes to open issues.

So that you don't have to review all of it, I've made a spreadsheet of all the commits, to start cataloguing which ones might be worth cherry-picking: https://docs.google.com/spreadsheets/d/1UNWTyzhm2K3i6n9gdBGhRKs7CnVyEV9IOXKBDlTIO3I/edit?usp=sharing

Let me know if you want edit access to the spreadsheet. If not, just know that I'm using this as a form of organization to systematically review and possibly make other PRs that cherry-pick commits.

NQNStudios avatar Jun 13 '24 17:06 NQNStudios

I already cherry-picked quite a few commits, and I'm not sure whether this PR excludes all of those, but I'd probably accept a PR that cherry-picks more, as long as they're not completely new features.

CelticMinstrel avatar Jun 13 '24 17:06 CelticMinstrel

I'm no longer planning to go through this for more stuff. Closing it.

Thanks Fosnola!

NQNStudios avatar Nov 19 '24 22:11 NQNStudios