cboe icon indicating copy to clipboard operation
cboe copied to clipboard

Restart Travis builds

Open madwizard opened this issue 5 years ago • 1 comments

Restart Travis-CI builds. To do this I had to:

  • move SConstruct to python3. Minor changes, xrange to range and print "" to print()
  • satisfy some compilers complaining about lack of includes
  • disable tests... yep
  • stop installing custom icons on Mac OS
  • install TGUI as it's now dependency and Ubuntu doesn't seem to have it repos

madwizard avatar Sep 23 '20 18:09 madwizard

Some general comments on your updates:

  • The contents of those strings should also be less heavily indented.
  • You need file=gitrev_hpp on the subsequent 4-5 lines as well.
  • Casting definitely is safer than changing the type without being sure it's safe in all cases; I'd prefer a static_cast but am not heavily attached to that.

CelticMinstrel avatar Sep 24 '20 12:09 CelticMinstrel

Closing since Travis is no longer in use, although if someone spots changes in this PR that are actually required in general, they are welcome to open a new PR with just those changes.

CelticMinstrel avatar Jan 05 '23 07:01 CelticMinstrel