karet icon indicating copy to clipboard operation
karet copied to clipboard

Bump React dependency and peer dependency to 17

Open abstracthat opened this issue 4 years ago • 5 comments

React 17 is out. I've tested this in a large Karet application and found no issues. This release will mostly just clear the npm warning for the React peer dependency.

abstracthat avatar Nov 13 '20 18:11 abstracthat

Thanks!

One issue is that tests are still run with 16.* due to the devDependencies specifying "react": "^16.8.0".

polytypic avatar Nov 18 '20 09:11 polytypic

I had that change locally but missed pushing it. Thanks @polytypic!

abstracthat avatar Nov 18 '20 16:11 abstracthat

Hmm... One more issue came to mind. Namely that since this is upgrading React major version from 16 to 17, then it would probably be best to also change the major version number of Karet (4.1.0 -> 5.0.0). That is because React is effectively an interface dependency that leaks through. Other than that this looks good!

polytypic avatar Nov 21 '20 10:11 polytypic

If you make the peerDep version something like ^16.8.0 || ^17.0.0, consumers can choose which major version they want to use and your package indicates that it works with both, so it wouldn't be a breaking change for people still on React 16.

mAAdhaTTah avatar Nov 22 '20 16:11 mAAdhaTTah

ping @abstracthat

bpinto avatar Jan 23 '21 17:01 bpinto