Jakob Borg

Results 671 comments of Jakob Borg

For logging (verbose service) purposes the event data things could implement Stringer as well.

Something like that, yes, but there's no need to panic. You only get a panic if you do a "hard" type assertion and get it wrong: ``` intf := subscription.Read()...

I see now your question wasn't really about that case, but the type assertion stuff applies anyway.

This is a worthy change and stalled by perhaps unnecessary perfectionism... How about accepting an approximate value as returned by something existing like moment.js `.humanize` and offering the precise timestamp...

Well, yeah, we keep saying people should use the API for this, and now we provide a CLI for the API, so this seems legit. Didn't look at the implementation...

The Windows posting failure seems consistent, not sure why...

I just merely glanced at the code and the previous discussion, so this is superficial. But this seems to echo precisely the discussion we had in your previous large PR,...

Let me take an actual look at this and see what I would do instead of theorising. If it's in the same size ballpark as what you did I'll shut...

I started on a thing with my preferred approach: https://github.com/syncthing/syncthing/compare/main...calmh:candnogui Basically, track the relevant things in a regular data structure, update it from the model calls, serialize as appropriate. I...

That would be awfully file type dependent; merging jpegs or word documents would suck, using vimdiff. :)