spotify-web-sdk icon indicating copy to clipboard operation
spotify-web-sdk copied to clipboard

Removes trivial lodash

Open danielmitre opened this issue 5 years ago • 2 comments

Description

Removes Lodash dependencies (all but lodash.snakeCase) that are easily replaceable by an one-line function and/or some ES6 feature. This aim to reduce the SDK bundle size, which it does (from 130Kib to 95.8Kib minimized without compression).

Most of changes were made writing a similar function just the complex enough to make the job done. Except for the startUserPlayback refactoring, but I can do the same there.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

danielmitre avatar Aug 20 '20 21:08 danielmitre

I kept this as a draft because I don't know if I should include a CHANGELOG.md update in the PR

danielmitre avatar Aug 20 '20 21:08 danielmitre

I saw this failed coming, but still can't replicate the failure in my local environment

danielmitre avatar Aug 22 '20 01:08 danielmitre