super-app-showcase icon indicating copy to clipboard operation
super-app-showcase copied to clipboard

chore: enable Module Federation's dts

Open borisyankov opened this issue 1 year ago • 4 comments

This should work, but currently 'dts' generation fails for all remotes.

Exception thrown inside dts-plugin.

We should use this a preproduction, until fixed.

borisyankov avatar Feb 01 '25 11:02 borisyankov

How is HMR performance affected? I recall turning dts on made recompilation super slow on rspack 1.0 and 1.1

thymikee avatar Feb 01 '25 11:02 thymikee

@jbroma said the perf issues were fixed on their side, and from my testing type generation looks fast enough.

The blocker is that the full process does not finish - @mf-types.zip is not created, though d.ts files are.

borisyankov avatar Feb 01 '25 13:02 borisyankov

How is HMR performance affected? I recall turning dts on made recompilation super slow on rspack 1.0 and 1.1

performance impact should be fixed already 👍

@jbroma said the perf issues were fixed on their side, and from my testing type generation looks fast enough.

The blocker is that the full process does not finish - @mf-types.zip is not created, though d.ts files are.

since problems like this are still there, and are not addressed we should hold off with enabling DTS here imo

jbroma avatar Feb 01 '25 21:02 jbroma

Oh, yeah. The error is definitely blocking for merging this PR.

But it might serve as a reproduction when reporting the issue to MF's guys.

borisyankov avatar Feb 03 '25 15:02 borisyankov