repack icon indicating copy to clipboard operation
repack copied to clipboard

fix: native module typing

Open jbroma opened this issue 1 year ago • 3 comments

Summary

Closes #494

Test plan

  • [x] - android new arch builds
  • [ ] - ios new arch builds

jbroma avatar Jun 09 '24 17:06 jbroma

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:41pm

vercel[bot] avatar Jun 09 '24 17:06 vercel[bot]

🦋 Changeset detected

Latest commit: da3056c100518df14e52a98fda8aa10c9b70111c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Minor
tester-federation Patch
@callstack/repack-dev-server Minor
@callstack/repack-init Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 09 '24 17:06 changeset-bot[bot]

It seems that for Android, the generated type stays as ReadableMap, but for iOS the codegen creates a struct for config argument. I'm not sure whether it's worth it to implement that, when we still have to keep compatibility for the old arch - we would have to fork (wrap in ifdefs in this case) a lot of code just to use the typings from codegen.

cc @troZee

jbroma avatar Jun 12 '24 10:06 jbroma

This pull request has been marked as stale because it has been inactive for 60 days. Please update this pull request or it will be automatically closed in 14 days.

github-actions[bot] avatar Jul 18 '24 00:07 github-actions[bot]