repack icon indicating copy to clipboard operation
repack copied to clipboard

Add cli-progress to the repack cli

Open emel95 opened this issue 1 year ago • 10 comments

Closes #369

I've been using Repack for quite a while and although the functionalities of this project impressed me, I wasn't happy with the way progress of bundling process was shown in the terminal. So, I rolled up my sleeves and tried to make it neater and as informative as before for the developers who want to utilize this package.

The package that I used for this matter is "cli-progress" and changed the "consoleReporters.js" file. Feel free to change the way progress is shown on the Terminal by changing the presets bundled with the mentioned package and let me know if any changes from my side was required.

emel95 avatar Jun 13 '23 16:06 emel95

⚠️ No Changeset found

Latest commit: 42b0116cbf10fbd5440af1dd570da2aa3be09236

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 13 '23 16:06 changeset-bot[bot]

💡 Do we want to have the progress bar in the same format as other logs? Because right know this progress bar is without any timestamp. cc. @RafikiTiki CleanShot 2023-06-15 at 14 16 06@2x

szymonrybczak avatar Jun 15 '23 12:06 szymonrybczak

@emel95 any updates? 🙏

szymonrybczak avatar Aug 08 '23 11:08 szymonrybczak

@szymonrybczak
hi I have fixed the issues you mentioned. I hope they are okay now. If there are any further problems, please let me know so that I can address them. Thank you.

emel95 avatar Aug 15 '23 16:08 emel95

hi @jbroma Thank you for your complete explanation, I changed the things you said, please check again

emel95 avatar Aug 20 '23 16:08 emel95

hi @jbroma any updates?🙏

emel95 avatar Sep 26 '23 17:09 emel95

Hi @emel95,

some of the issues I mentioned above are still not resolved, try bundling 2 apps at once and see how the progress bars just keep overwriting themselves.

P.S. I realise this not a trivial issue to fix

jbroma avatar Sep 27 '23 10:09 jbroma

This pull request has been marked as stale because it has been inactive for 60 days. Please update this pull request or it will be automatically closed in 14 days.

github-actions[bot] avatar Dec 07 '23 00:12 github-actions[bot]

hi I will try to start these mentioned items in a few days and fix them as soon as possible

emel95 avatar Dec 10 '23 13:12 emel95

This pull request has been marked as stale because it has been inactive for 60 days. Please update this pull request or it will be automatically closed in 14 days.

github-actions[bot] avatar Jan 20 '24 00:01 github-actions[bot]

This pull request has been automatically closed because it has been inactive for more than 14 days. Please reopen if you still intend to submit this pull request.

github-actions[bot] avatar Mar 21 '24 00:03 github-actions[bot]