reassure icon indicating copy to clipboard operation
reassure copied to clipboard

[FEATURE] Build GH action to run perf tests

Open mdjastrzebski opened this issue 2 years ago • 5 comments

Is your feature request related to a problem? Please describe. Currently we piggy back on Danger JS to offer support to popular CIs. This request is about building direct integration with GitHub actions.

Describe the solution you'd like

  • GH action that directly integrates with Reassure.
  • Separate package in the monorepo
  • Does not use Danger JS

Describe alternatives you've considered None

Additional context None

mdjastrzebski avatar Jun 23 '22 08:06 mdjastrzebski

Hey @mdjastrzebski ,

Can you please share a bit more context on the action ? When we say we are seeking to support an action that integrates with Reassure on the CI ...

ShaswatPrabhat avatar Oct 04 '22 17:10 ShaswatPrabhat

Hi @mdjastrzebski ,

I wanted to take a shot at this. Please let me know if we have any other pointers to start with or tech notes on this.

Thanks in advance

ShaswatPrabhat avatar Oct 05 '22 13:10 ShaswatPrabhat

We basically want to duplicate what our Danger plugin does right now:

  • read the .reassure/output.md file and display the contained markdown inside GH PR
  • fail in case no output file is found
  • in should accept an option to specify the path to output file

That's basically it.

mdjastrzebski avatar Oct 20 '22 12:10 mdjastrzebski

Thanks @mdjastrzebski I will pick this up and give it a shot.

ShaswatPrabhat avatar Oct 21 '22 04:10 ShaswatPrabhat

Hey @mdjastrzebski,

Please find the PR for the change.

Was able to integrate it like ShaswatPrabhat/reassure/packages/reassure-gh-action@feat/custom_gh_actions not sure if that is the recommended way though, Had tried a few alternatives before this.

Been able to integrate it, but as the branch is a fork hence not able to run the new job.

Please suggest. Thanks in advance

ShaswatPrabhat avatar Oct 30 '22 08:10 ShaswatPrabhat