react-native-slider icon indicating copy to clipboard operation
react-native-slider copied to clipboard

Wrong in Task :react-native-community_slider:compileReleaseJavaWithJavac FAILED

Open orlandoneto23 opened this issue 1 year ago • 1 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @react-native-community/[email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
index 7c05916..23f0c49 100644
--- a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
+++ b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
@@ -11,6 +11,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
+import com.facebook.react.uimanager.events.RCTEventEmitter;
 
 /**
  * Event emitted by a ReactSliderManager when user changes slider position.
@@ -42,13 +43,18 @@ public class ReactSliderEvent extends Event<ReactSliderEvent> {
     return EVENT_NAME;
   }
 
+  @Override
+  public void dispatch(RCTEventEmitter rctEventEmitter) {
+
+  }
+
   @Override
   public short getCoalescingKey() {
     return 0;
   }
 
   @Nullable
-  @Override
+  //@Override
   protected WritableMap getEventData() {
     return serializeEventData();
   }
diff --git a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java
index ffdd8de..766249e 100644
--- a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java
+++ b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingCompleteEvent.java
@@ -11,6 +11,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
+import com.facebook.react.uimanager.events.RCTEventEmitter;
 
 /**
  * Event emitted when the user finishes dragging the slider.
@@ -35,7 +36,12 @@ public class ReactSlidingCompleteEvent extends Event<ReactSlidingCompleteEvent>
         return EVENT_NAME;
     }
 
-    @Override
+  @Override
+  public void dispatch(RCTEventEmitter rctEventEmitter) {
+
+  }
+
+  @Override
     public short getCoalescingKey() {
         return 0;
     }
@@ -46,7 +52,7 @@ public class ReactSlidingCompleteEvent extends Event<ReactSlidingCompleteEvent>
     }
 
     @Nullable
-    @Override
+    //@Override
     protected WritableMap getEventData() {
         return serializeEventData();
     }
diff --git a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java
index 3a7ace7..8aa596e 100644
--- a/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java
+++ b/node_modules/@react-native-community/slider/android/src/main/java/com/reactnativecommunity/slider/ReactSlidingStartEvent.java
@@ -11,6 +11,7 @@ import androidx.annotation.Nullable;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
 import com.facebook.react.uimanager.events.Event;
+import com.facebook.react.uimanager.events.RCTEventEmitter;
 
 /**
  * Event emitted when the user starts dragging the slider.
@@ -35,7 +36,12 @@ public class ReactSlidingStartEvent extends Event<ReactSlidingStartEvent> {
         return EVENT_NAME;
     }
 
-    @Override
+  @Override
+  public void dispatch(RCTEventEmitter rctEventEmitter) {
+
+  }
+
+  @Override
     public short getCoalescingKey() {
         return 0;
     }
@@ -46,7 +52,7 @@ public class ReactSlidingStartEvent extends Event<ReactSlidingStartEvent> {
     }
 
     @Nullable
-    @Override
+    //@Override
     protected WritableMap getEventData() {
         return serializeEventData();
     }

This issue body was partially generated by patch-package.

orlandoneto23 avatar Dec 27 '23 12:12 orlandoneto23

Hello @orlandoneto23, could you provide more details about the environment and some reproduction steps for this to happen ? Maybe check with the latest version if this is not resolved.

draggie avatar Sep 20 '24 06:09 draggie

Closing this issue as there have been no further reports and it seems to no longer be present. If this problem resurfaces or you encounter a related issue, please feel free to open a new issue or comment here. Thanks for your contribution and for helping improve the project!

draggie avatar Nov 22 '24 09:11 draggie