react-native-slider icon indicating copy to clipboard operation
react-native-slider copied to clipboard

Android: Apply slider padding from css

Open BlackJohnny opened this issue 4 years ago • 6 comments

Summary:

This PR applies the padding information from the CSS style associated to the Slider component.

This can be useful when you need to add some overlay on the slider.

NOTE: I did not add the support for IOS. Maybe someone could help with this.

Test Plan:

<Slider
    ...
    style={{paddingLeft: 10, paddingRight: 10}}
    />

or

<Slider
    ...
    style={{padding: 10}}
    />

BlackJohnny avatar Apr 03 '20 16:04 BlackJohnny

Boss, will you merge, reject or request to update this feature? :)

BlackJohnny avatar Apr 15 '20 19:04 BlackJohnny

Since its java only, we will wait for iOS impl

wojteg1337 avatar May 11 '20 07:05 wojteg1337

Please fix for ios also

HITESH122 avatar Jan 21 '21 21:01 HITESH122

@BlackJohnny & @wojteg1337 I believe that this could solve the #258, how do you think?

BartoszKlonowski avatar Oct 20 '21 22:10 BartoszKlonowski

Any news on this?

brycnguyen avatar Dec 13 '22 23:12 brycnguyen

It would be nice if we could fix the padding issue #258

tastafur avatar Dec 29 '22 12:12 tastafur