react-native-slider icon indicating copy to clipboard operation
react-native-slider copied to clipboard

Add thumbSize as a prop (or even thumbStyle)

Open CezarCobuz opened this issue 5 years ago • 22 comments

Only thumbTintColor offers too little flexibility - thumbSize is needed

The size of the thumb can NOT be controlled without affecting the whole slider. On iOS the thumb is significantly bigger than on Android. Even by adding a thumb image scales different from one platform to another. At this point there is no way to apply a fixed thumb size for consistency over the two platforms.

CezarCobuz avatar Apr 03 '20 08:04 CezarCobuz

this PR takes care of this for the web implementation if it gets merged. There would be only the native implementation to be done.

I added thumbSize, trackHeight and thumbStyle props

Sharcoux avatar Apr 07 '20 15:04 Sharcoux

By the way, there could be a quick fix for this: the web implementation should be working perfectly fine for native too, so we could just use the web implementation as the universal implementation. What do you think @michalchudziak ? Of course we would need to ensure that no feature provided by the current native implementation is missing. But is this a path that would be acceptable?

Sharcoux avatar Apr 15 '20 08:04 Sharcoux

@michalchudziak? Your opinion about it?

Sharcoux avatar Apr 30 '20 09:04 Sharcoux

+1

n0umankhan avatar May 02 '20 11:05 n0umankhan

Curious where this stands for mobile - would be a helpful feature. Thanks for your contributions toward it!

kevinhylant avatar May 18 '20 19:05 kevinhylant

+1

TN-Figueiredo avatar May 19 '20 15:05 TN-Figueiredo

The lack of traction on this issue is surprising to me; This seems critical for anyone who intends to use this slider across multiple platforms and cares for consistency...

nickarora avatar Jun 07 '20 22:06 nickarora

+1

agnieszkabugla avatar Jul 22 '20 09:07 agnieszkabugla

Please we need a fix thumb value for android and ios

ShivamJoker avatar Jul 28 '20 09:07 ShivamJoker

+1

arthur-vargas avatar Oct 07 '20 19:10 arthur-vargas

+1

raphaelrupprecht avatar Oct 14 '20 18:10 raphaelrupprecht

@raphaelrupprecht @arthur-vargas @ShivamJoker if you need something for now, just try @sharcoux/slider from npm. It is open source and used and maintained by my company. You can ask if you have issues.

Sharcoux avatar Oct 14 '20 19:10 Sharcoux

In addition to thumbsize support another deal breaker is the ghastly box shadow thats on the thumb handle by default. There should be a way to remove that or just support style prop and call it a day!

TowhidKashem avatar Dec 02 '20 03:12 TowhidKashem

+1

AlisanCakir avatar Apr 14 '21 14:04 AlisanCakir

+1

patissier-boulanger avatar Oct 13 '21 06:10 patissier-boulanger

+1

wilav-dev avatar May 14 '22 03:05 wilav-dev

+1

ludvigeriksson avatar May 30 '22 17:05 ludvigeriksson

+1

SamiChab avatar Jun 18 '22 01:06 SamiChab

+1

brunoleitem avatar Jul 01 '22 14:07 brunoleitem

+1

vietnt-uet avatar Aug 10 '22 07:08 vietnt-uet

+1

mhackeras avatar Aug 11 '22 11:08 mhackeras

+1

artfxx avatar Aug 26 '22 04:08 artfxx

+1

OneTuskedMario avatar Nov 08 '22 15:11 OneTuskedMario

Hello,

I've also this issue. Something is already in progress to allow this ? Thanks

mguyard avatar Dec 31 '22 15:12 mguyard

I would like to keep it as one feature request opened in #40. I will close this one, but please keep the track in the mentioned issue.

BartoszKlonowski avatar Jan 18 '23 14:01 BartoszKlonowski