react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

Published 20 hours ago • verified publisher icon callstack

fix: no longer spread key prop on BottomNavigationBar - resolves #4401

Open nick42d opened this issue 1 year ago • 3 comments

Motivation

Resolves #4401 with suggested fix from @CommanderRedYT

Related issue

#4401

Test plan

Tested following contribution guidelines https://github.com/callstack/react-native-paper/blob/main/CONTRIBUTING.md

nick42d avatar Sep 12 '24 23:09 nick42d

Hey @nick42d, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar Sep 12 '24 23:09 callstack-bot

any update?

hello-ccchen avatar Oct 10 '24 02:10 hello-ccchen

We are waiting for this too, would be great to have this merged and included in the next release. Thanks

prageeth avatar Oct 12 '24 11:10 prageeth

Is this going to get merged?

skoolaidl avatar Nov 07 '24 23:11 skoolaidl

come on guys! launch a new release asap!

shuffledex avatar Nov 13 '24 17:11 shuffledex

any update? 🥹

hello-ccchen avatar Dec 20 '24 09:12 hello-ccchen

Please guys. Launch a new release with this fix.

lourencorodrigo avatar Dec 22 '24 22:12 lourencorodrigo

wait a release~

zeevenn avatar Dec 28 '24 15:12 zeevenn

could you merge this? @callstack-bot

RSginer avatar Jan 03 '25 11:01 RSginer

100% of native devices not able to use the <BottomNavigation /> . Maybe the discussion can be a follow-up task here.

artiphishle avatar Jan 06 '25 18:01 artiphishle

Is there news on this?

StevenMartinMedgate avatar Feb 04 '25 07:02 StevenMartinMedgate

This PR can be closed now, turns out this is fixed (although not in isolation or from an existing PR) I can confirm it works without warning on the latest version.

https://github.com/callstack/react-native-paper/commit/77d3af73a2db020da4a2a90592a4eda030e2a2ee#diff-54d07d0dd9a891cd54e08e7642d895b92a592e9294af566460fa17dab475fa0eL363

ChromeQ avatar Feb 11 '25 12:02 ChromeQ

This PR can be closed now, turns out this is fixed (although not in isolation or from an existing PR) I can confirm it works without warning on the latest version.

77d3af7#diff-54d07d0dd9a891cd54e08e7642d895b92a592e9294af566460fa17dab475fa0eL363

Confirmed, Callstack merged this change as part of a larger PR as ChromeQ mentioned.

nick42d avatar Feb 13 '25 23:02 nick42d