react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

Published 20 hours ago • verified publisher icon callstack

chore: testing library adjustments

Open lukewalczak opened this issue 3 years ago • 4 comments
trafficstars

Summary

PR introduces some adjustments according to the comment from the previously merged PR.

Test plan

Test and CI should pass.

lukewalczak avatar Aug 12 '22 09:08 lukewalczak

Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar Aug 12 '22 09:08 callstack-bot

The mobile version of example app from this branch is ready! You can see it here

.

github-actions[bot] avatar Aug 12 '22 09:08 github-actions[bot]

Two general suggestions:

  1. Try to use custom jest matchers from @testing-library/jest-native these should allow you to make more high-level assertions
  2. Gradually migrate to use screen object to make queries:

Thanks for the feedback, both of them make sense. I will iterate on it in the separated PRs.

EDIT:

Try to use custom jest matchers from @testing-library/jest-native these should allow you to make more high-level assertions

Included in the current PR.

lukewalczak avatar Aug 12 '22 13:08 lukewalczak

The mobile version of example app from this branch is ready! You can see it here

.

github-actions[bot] avatar Aug 12 '22 15:08 github-actions[bot]