react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

Make Menu component SCREEN_INDENT configurable.

Open bombillazo opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. I have some screens using TextInputs that must be flush to the screen edges. Rather than having a whole separate TextInput component or working around styles, it would be great to have this value overrideable.

Describe the solution you'd like Expose this property somehow to be able to override this value. Describe alternatives you've considered Either have a separate component (impractical since it would break UI consistency of using RNP) or programmatically remove this gap by offsetting the gap, which is not performant and complicates the code.

Additional context Want to remove this gap caused by SCREEN_INDENT image

react-native: 0.69.3 react-native-paper: 4.12.4 react-native-vector-icons: 9.2.0

bombillazo avatar Aug 07 '22 13:08 bombillazo

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.dev link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

github-actions[bot] avatar Aug 07 '22 13:08 github-actions[bot]

Couldn't find version numbers for the following packages in the issue:

  • react-native
  • react-native-paper
  • react-native-vector-icons

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

github-actions[bot] avatar Aug 07 '22 13:08 github-actions[bot]

Hey @bombillazo, I think we can introduce an optional property, which can override the hardcoded value. If you would like to handle that, please open a PR.

lukewalczak avatar Aug 08 '22 14:08 lukewalczak

Hey, sure, Ill try to get something done

bombillazo avatar Aug 19 '22 20:08 bombillazo

Hey, Im closing this as the use case changed and I no longer require to change this.

bombillazo avatar Sep 06 '22 18:09 bombillazo