react-native-paper feat: adjust theme types to match internal and regular usage

feat: adjust theme types to match internal and regular usage

Open Drakeoon opened this issue 3 years ago • 3 comments

trafficstars

During the development we came to the conclusion that useTheme right now has to serve too many roles - support two themes at the same time for internal components and later on support just one theme when used by developers including react-native-paper into their applications

Summary

[x] Added useInternalTheme hook for internal usage
[x] Added withInternalTheme HOC for internal usage
[x] Renamed global type definition
[x] Change usage inside internal components
[x] Raised a PR in @callstack/react-theme-provider to allow typing hooks

Test plan

Due to the usage of global index.d.ts files I had troubles with testing the implementation inside example folder. My idea now is to create a separate app, include react-native-paper from this branch and see if global theme overrides work properly

Jul 26 '22 07:07 Drakeoon

@lukewalczak CircleCI tests fail due to missing implementation in @callstack/react-theme-provider - I'll raise the PR today

Jul 26 '22 07:07 Drakeoon

Hey @Drakeoon, thank you for your pull request 🤗. The documentation from this branch can be viewed here.