fix: active input label color no longer overwritten by border color

[r6rob]

Summary

Resolving an issue outlined here that is caused by the activeUnderlineColor/activeOutlineColor overriding activeColor for the TextInput component. This makes it impossible to set an activeUnderlineColor/activeOutlineColor without also overriding the input label color.

Now the active underline/outline color is set as it's passed to the outline/underline component and does not affect the label.

Test plan

Ensure the border, underline, and input label colors can all be changed independently of each other, (using outlineColor, underlineColor, activeOutlineColor, activeUnderlineColor, and primary theme color for input label).

[callstack-bot]

Hey @r6rob, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

[jsnavarroc]

Hi there, what else needs to merge with this pull request?

[johanjq]

can we merge this one? is there something I can do to help out and get this one in?

[r6rob]

@p-syche I'm also happy to help

[p-syche]

@r6rob thank you for your PR 🏅 However I'm not sure your changes are the best solution to the problem described in the issue. The problem described in issue #2987 concerns transparent underlines only. I understand the way you're thinking: now the colors are not linked and everyone can set whatever they want. But I'm afraid the library users want to have the colors set "automagically" if you will, and your change breaks that behavior. Do you think you could find a solution to only fix the transparent underline?