react-native-paper icon indicating copy to clipboard operation
react-native-paper copied to clipboard

Published 20 hours ago • verified publisher icon callstack

fix: aligned the icons in the Menu

Open samkevin1 opened this issue 4 years ago • 3 comments

Summary

Saw an issue where the icons in the menu were not properly aligned. So just added this line of code to fix that.

Test plan

Before: Screenshot from 2021-02-23 08-59-22

After: Screenshot from 2021-02-23 08-59-57

samkevin1 avatar Feb 23 '21 12:02 samkevin1

Hey @samkevin1, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

callstack-bot avatar Feb 23 '21 12:02 callstack-bot

Looks fine, just not sure about it, because material design does not follow icon support for mobile..

Desktop has different horizontal spacing: (24 x 20)

image

@Trancever Maybe we should set the icons margin to be left X+4 and right to X (Left: 16, Right: 12)?

wojteg1337 avatar Mar 01 '21 13:03 wojteg1337

Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days.

github-actions[bot] avatar May 01 '21 00:05 github-actions[bot]