react-native-pager-view icon indicating copy to clipboard operation
react-native-pager-view copied to clipboard

chore: migrate example to `react-native-test-app`

Open szymonrybczak opened this issue 1 year ago • 3 comments

Summary

In this Pull Request I've migrated Example project to react-native-test-app.

Old arch New arch (Bridgeless)
Android CleanShot 2024-06-19 at 10 42 05@2x CleanShot 2024-06-19 at 10 31 45@2x
iOS CleanShot 2024-06-19 at 10 46 24@2x CleanShot 2024-06-19 at 10 32 11@2x

Test Plan

App should properly run and build on all platforms that react-native-pager-view supports.

Compatibility

OS Implemented
iOS
Android
visionOS

Checklist

  • [x] I have tested this on a device and a simulator
  • [ ] I added the documentation in README.md
  • [ ] I updated the typed files (TS and Flow)

szymonrybczak avatar Jun 18 '24 13:06 szymonrybczak

@szymonrybczak could you rebase your PR? 🙏

troZee avatar Jun 19 '24 06:06 troZee

CI is failing for iOS E2E tests because app built inside Release mode cannot grab .jsbundle, I tried also in a fresh project and it looks like something is broken: CleanShot 2024-07-01 at 15 12 41@2x

npx --package react-native-test-app@latest init
yarn build:ios
yarn ios --mode "Release"

cc: @tido64 any ideas? Is there maybe anything that I'm missing in the config for app to run properly?

szymonrybczak avatar Jul 01 '24 13:07 szymonrybczak

cc: @tido64 any ideas? Is there maybe anything that I'm missing in the config for app to run properly?

When is pod install run? It needs to be run after bundling so that CocoaPods can create an entry for it in the generated Xcode project files. You can check if it's present if you open .xcworkspace in Xcode.

tido64 avatar Jul 02 '24 00:07 tido64

@tido64 I did give it a try, and it seems like the results is still the same :(

szymonrybczak avatar Jul 08 '24 08:07 szymonrybczak

@szymonrybczak Do you have repro steps? Seems to work for me. This is what I ran:

yarn
cd example
yarn
yarn build:ios
pod install --project-directory=ios
yarn ios --no-packager --simulator 'iPhone 15 Pro'

image

tido64 avatar Jul 15 '24 08:07 tido64