callstack
Revert "feat(ios): back gesture with full screen swipe (#705)"
This reverts commit 769a3a21500fbe40c1909c9bf50f724c76a5b435.
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
| OS | Implemented |
|---|---|
| iOS | ✅❌ |
| Android | ✅❌ |
Checklist
- [ ] I have tested this on a device and a simulator
- [ ] I added the documentation in
README.md - [ ] I updated the typed files (TS and Flow)
https://github.com/callstack/react-native-pager-view/commit/769a3a21500fbe40c1909c9bf50f724c76a5b43 made it stop working for me as well with react-native-collapsible-tab-view
@intergalacticspacehighway Can we revert your changes? Maybe we should consider adding this fix https://github.com/callstack/react-native-pager-view/pull/705#issuecomment-1483855040
@td-tomasz-joniec what functionality will be broken, when this patch is removed? Will it introduce some regression?
@zRelux what has stopped working? Can you please explain the issue?
@troZee reverting can break the back gesture when fullScreenSwipeEnabled is enabled for pop react-navigation. Not a massive breaking change, but I am still unclear on the reason for reverting.
The additional issue asked here is a different feature request to support non-native stack (allow swiping back from the edge when currentPage > 0 and using non-native stack). I can look into that but that won't be solved even if we revert this PR.
@intergalacticspacehighway Can we revert your changes? Maybe we should consider adding this fix #705 (comment)
@td-tomasz-joniec what functionality will be broken, when this patch is removed? Will it introduce some regression?
I am only interested in reverting this change as this code breaks correct touch handling when pager view is inside scrollview
@td-tomasz-joniec are you facing this https://github.com/callstack/react-native-pager-view/issues/722 issue or is it something else?
@intergalacticspacehighway swipe back navigation when using react-native-collapsible-tab-view
@zRelux does reverting the changes fix the issue? Can you confirm if you are using the regular stack from react-navigation and not the native stack navigator?
Yes I downgraded to 6.1.4 (release before the fix) and it works, I am using stack from expo-router (which I believe is the native one)
@zRelux can you share a repro? I tried creating one here with the expo router, but not able to reproduce the issue.
https://github.com/callstack/react-native-pager-view/assets/23293248/bc7095e7-01de-4959-8e4d-1b01e1e713b4
Any update ? still not working for me even on 6.1.4, I'm using @react-navigation non native Stack and react-native-collapsible-tab-view @intergalacticspacehighway
Any update ? still not working for me even on 6.1.4, I'm using @react-navigation non native Stack and react-native-collapsible-tab-view @intergalacticspacehighway
Could you provide a repro? It will definitely speed it up. Right now, I cannot reproduce it
I'm facing an issue with gesture detection in my React Native project. I'm implementing a custom tab view and also using a pager component. The problem arises because, when using these together, the gesture detection doesn't work as expected. It seems like one gesture handler is overriding or interfering with the others, leading to some gestures not being detected at all. This results in interaction issues, where users can't swipe or interact with the views properly.
The specific problem is that the pager's gesture detection takes priority, which then disables or limits the gestures in my custom tab view. I'm looking for a solution that allows both components to handle gestures independently without conflict, ensuring smooth and expected behavior in my app's UI.
Closing as https://github.com/callstack/react-native-pager-view/pull/933 was merged
