react-native-pager-view icon indicating copy to clipboard operation
react-native-pager-view copied to clipboard

chore: fabric migration

Open troZee opened this issue 3 years ago • 2 comments

Current State

Only Basic iOS features have been implemented so far

Summary

Add a new arch to the pager library.

Used docs/code examples: https://github.dev/software-mansion/react-native-screens/tree/main/FabricExample https://github.dev/th3rdwave/react-native-safe-area-context https://github.dev/cortinico/RNNewArchitectureApp/tree/ios/20220309

New API: https://github.com/facebook/react-native/blob/8bd3edec88148d0ab1f225d2119435681fbbba33/React/Fabric/Mounting/RCTComponentViewProtocol.h

Discussion: https://github.com/reactwg/react-native-new-architecture/discussions/16

Test Plan

  1. on iOS
    • Install pods using RCT_NEW_ARCH_ENABLED=1 pod install – this is the same command you run to prepare a Fabric build but you also need to run it after a new native library gets added.
  2. on Android
    • There are no additional steps required so long you app is configured to build with Fabric – this is typically configured by setting newArchEnabled=true in gradle.properties file in your project.

Compatibility

OS Implemented
iOS
Android

Checklist

  • [ ] iOS: migrate all features to the new arch
  • [ ] Android: migrate all features to the new arch
  • [ ] Create a legacy fallback
  • [ ] Create a separate example for Fabric and Paper arch

TO IMPLEMENT ON iOS

  • [ ] LTR
  • [ ] overdrag
  • [ ] issue with jumping tabs

troZee avatar Mar 16 '22 11:03 troZee

Any update on this @troZee ? Will the current release of react-native-view-pager still work if I update my project to RN 0.68.X or newer?

pang0018 avatar May 09 '22 14:05 pang0018

@troZee can you publish this in the Alpha/beta version?

numandev1 avatar Aug 25 '22 10:08 numandev1

@troZee can you publish this in the Alpha/beta version?

https://github.com/callstack/react-native-pager-view/blob/master/README.md#new-architecture-support-fabric

Please let me know, if everything is ok.

troZee avatar Sep 22 '22 16:09 troZee