react-native-pager-view icon indicating copy to clipboard operation
react-native-pager-view copied to clipboard

Published 20 hours ago • verified publisher icon callstack

Resolve RLT support

Open ghoudi01 opened this issue 3 years ago • 19 comments

resolve rtl support

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • [X] I have tested this on a device and a simulator
  • [ ] I added the documentation in README.md
  • [ ] I updated the typed files (TS and Flow)

ghoudi01 avatar Nov 28 '21 10:11 ghoudi01

Could you please check this PR ASAP?

@satya164 @troZee This bug affects the rtl-based app that has been migrated toreact-navigation@6 orreact-native-tab-view@3.

Refer to https://github.com/satya164/react-native-tab-view/issues/1266

theMasix avatar Nov 28 '21 15:11 theMasix

Could you please check this PR ASAP?

Can you not ping me on the weekend for a 5 hour old PR? If the PR is necessary for you then use patch-package to temporarily use it in your project.

satya164 avatar Nov 28 '21 15:11 satya164

Can this PR get Merged, please?

Hady207 avatar Dec 05 '21 07:12 Hady207

any news about the test ?

ghoudi01 avatar Dec 06 '21 08:12 ghoudi01

Can this PR get Merged

ghoudi01 avatar Dec 27 '21 18:12 ghoudi01

Can this Pull Request be merged?

AhmedHalbas avatar Jan 02 '22 08:01 AhmedHalbas

Any updates about this issue?

YogiHa avatar Jan 18 '22 13:01 YogiHa

@ghoudi01 check the above! i == _currentIndex as like in the block above. Will avoid treating the same page.

react-one avatar Jan 19 '22 12:01 react-one

Are there's any reason why this PR not merged?

YogiHa avatar Feb 28 '22 14:02 YogiHa

there is still problem with this patch when setting the device language to RTL (Hebrew or Arabic )

RodinHatokayTe avatar Mar 28 '22 06:03 RodinHatokayTe

Any updates about this issue?

PeterWadie avatar May 01 '22 20:05 PeterWadie

@satya164, I know you didn't want to be tagged 5 hours after this PR was made, but it's now been 6 months - any update on merging this or why this hasn't been merged yet? Thanks

m-deacon avatar May 15 '22 17:05 m-deacon

@m-deacon I am not a maintainer of this repo. Please don't tag me.

satya164 avatar May 15 '22 17:05 satya164

@satya164, I know you didn't want to be tagged 5 hours after this PR was made, but it's now been 6 months - any update on merging this or why this hasn't been merged yet? Thanks

Hello, For now I cannot merge this PR, since it has conflicts. Please provide a proper description and repo steps, then I will be able to check the changes

troZee avatar May 18 '22 11:05 troZee

@ghoudi01 will you update your PR ?

troZee avatar May 20 '22 09:05 troZee

Any update on this thread??

Roshdy avatar Aug 10 '22 23:08 Roshdy

@troZee Here is a repo:

import React from 'react';
import { I18nManager, StyleSheet, Text, View } from 'react-native';
import PagerView from 'react-native-pager-view';

I18nManager.forceRTL(true)
I18nManager.allowRTL(true)

const App = () => {
  return (
    <PagerView style={styles.pagerView} initialPage={0}>
      <View key='1'>
        <Text>First page</Text>
      </View>
      <View key='2'>
        <Text>Second page</Text>
      </View>
    </PagerView>
  )
}

const styles = StyleSheet.create({
  pagerView: {
    flex: 1,
  },
})

export default App

Scroll left to the second page, and then try to scroll back to the first page. It doesn't work. This also effects react-native-tab-view where you can't go to another tab.

omerts avatar Sep 11 '22 19:09 omerts

Any update on this thread??

This PR breaks current pager behaviour. Please add a fix without breaking anything

troZee avatar Sep 13 '22 06:09 troZee

Hey @troZee https://github.com/callstack/react-native-pager-view/pull/613 raised this pr to properly fix this issue please check and merge is everything looks alright

sebasg0 avatar Oct 03 '22 21:10 sebasg0