linaria icon indicating copy to clipboard operation
linaria copied to clipboard

PR: 1144 introduces a breaking peer dependency for projects using rollup v3

Open joeuy opened this issue 3 years ago • 0 comments

Description

File: packages/rollup/package.json Problem introduced: https://github.com/callstack/linaria/pull/1144/files#diff-232fb48cd9aa0d8ebee4d609121ba2bb5dcef260b741a16e4af256df7b659877R16

Basically now npm i will fail for projects utilizing rollup v3. Could we include rollup v3 on peer dependency version? Happy to send a PR if thats ok.

cc: @Anber

Reproducible Demo

npm i [email protected]
npm i @linaria/[email protected]

Example error:

npm ERR! Found: [email protected]
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"3.7.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"1.20.0||^2.0.0" from @linaria/[email protected]
npm ERR! node_modules/@linaria/rollup
npm ERR!   dev @linaria/rollup@"4.3.1" from the root project

joeuy avatar Dec 10 '22 20:12 joeuy