pop-playground icon indicating copy to clipboard operation
pop-playground copied to clipboard

valueCount(nil) should be valueCount(0)

Open warpling opened this issue 10 years ago • 8 comments

The following line (53 in POPPropertyAnimationInternal.h) causes an error

 _POPPropertyAnimationState(id __unsafe_unretained anim) : _POPAnimationState(anim),
 ...
 valueCount(nil),
 ...

I believe the fix is as simple as changing it to valueCount(0), but maybe I'm overlooking something.

warpling avatar Mar 03 '15 11:03 warpling

Full error: /Users/ryanmcleod/Code/pop-playground-master/Pods/pop/pop/POPPropertyAnimationInternal.h:53:3: Cannot initialize a member subobject of type 'NSUInteger' (aka 'unsigned long') with an rvalue of type 'nullptr_t'

warpling avatar Mar 03 '15 11:03 warpling

I got the same error. Anyone have an idea?

nickbewley avatar Mar 04 '15 19:03 nickbewley

Replacing it with '0' seems to be okay.

On Wed, Mar 4, 2015 at 11:55 AM, Nick Bewley [email protected] wrote:

I got the same error. Anyone have an idea?

Reply to this email directly or view it on GitHub: https://github.com/callmeed/pop-playground/issues/5#issuecomment-77233293

warpling avatar Mar 04 '15 19:03 warpling

Same error here, replacing with 0 seems to work

natemcguire avatar May 02 '15 16:05 natemcguire

Could someone PR?

Thanks

Francescu avatar May 18 '15 12:05 Francescu

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

warpling avatar May 18 '15 15:05 warpling

Ok I updated the podlock

— Sent from Mailbox

On Mon, May 18, 2015 at 5:02 PM, Ryan McLeod [email protected] wrote:

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Reply to this email directly or view it on GitHub: https://github.com/callmeed/pop-playground/issues/5#issuecomment-103088118

Francescu avatar May 18 '15 19:05 Francescu

👍

On Mon, May 18, 2015 at 3:21 PM, Francescu Santoni [email protected] wrote:

Ok I updated the podlock — Sent from Mailbox On Mon, May 18, 2015 at 5:02 PM, Ryan McLeod [email protected] wrote:

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Reply to this email directly or view it on GitHub:

https://github.com/callmeed/pop-playground/issues/5#issuecomment-103088118

Reply to this email directly or view it on GitHub: https://github.com/callmeed/pop-playground/issues/5#issuecomment-103181455

warpling avatar May 18 '15 21:05 warpling