clubhouse-desktop icon indicating copy to clipboard operation
clubhouse-desktop copied to clipboard

Published 20 hours ago • verified publisher icon callmearta

Fix mute button

Open jishnu7 opened this issue 3 years ago • 5 comments

Clubhouse api doesn't send unmute field for the active user. So we should keep our own flag to store the status.

Fixes https://github.com/callmearta/clubhouse-desktop/issues/48

jishnu7 avatar Jun 02 '21 05:06 jishnu7

I can confirm that the state of the mute button is consistent now. But the mute status shown on the icon of the user is inconsistent. It goes back to mute state if we refresh the room. see the below screenshot. you can see that even when the user is in unmute, it is shown as mute on the profile icon. image

stultus avatar Jun 02 '21 22:06 stultus

@stultus That should be fixed now. Let me know if it works.

jishnu7 avatar Jun 03 '21 03:06 jishnu7

I should check this one. I'll test it when i have the time and if it worked i'll merge it. Thank you for your PR

callmearta avatar Jun 03 '21 08:06 callmearta

@callmearta were you able to test this?

stultus avatar Jun 16 '21 16:06 stultus

The code is not verified

borhanak avatar Jul 02 '21 11:07 borhanak