calliope
calliope copied to clipboard
Allowing complete math overrides
Fixes #606
Summary of changes in this pull request
- Introduces a new parameter (
config.init.base_math) that will tell the model to skip base math if set toFalse. - Run mode math updates have been moved from the backend to the main model file.
- Math is now always validated when modified (either in
initorbuild). This is to prevent unexpected surprises if users save an initialized model without building it.
Reviewer checklist
- [ ] Test(s) added to cover contribution
- [ ] Documentation updated
- [ ] Changelog updated
- [ ] Coverage maintained or improved
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.94%. Comparing base (
8c92ba5) to head (e47e12f).
:exclamation: Current head e47e12f differs from pull request most recent head 280da69
Please upload reports for the commit 280da69 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## fix-config-desync #609 +/- ##
=====================================================
+ Coverage 95.93% 95.94% +0.01%
=====================================================
Files 24 24
Lines 3638 3651 +13
Branches 736 735 -1
=====================================================
+ Hits 3490 3503 +13
Misses 84 84
Partials 64 64
Turns out our data saving steps have some unexpected bugs. Opened #614 to deal with them.
Converting to draft because #614 is a blocker to this PR.