calliope icon indicating copy to clipboard operation
calliope copied to clipboard

Allowing complete math overrides

Open irm-codebase opened this issue 1 year ago • 3 comments

Fixes #606

Summary of changes in this pull request

  • Introduces a new parameter (config.init.base_math) that will tell the model to skip base math if set to False.
  • Run mode math updates have been moved from the backend to the main model file.
  • Math is now always validated when modified (either in init or build). This is to prevent unexpected surprises if users save an initialized model without building it.

Reviewer checklist

  • [ ] Test(s) added to cover contribution
  • [ ] Documentation updated
  • [ ] Changelog updated
  • [ ] Coverage maintained or improved

irm-codebase avatar Jun 19 '24 09:06 irm-codebase

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.94%. Comparing base (8c92ba5) to head (e47e12f).

:exclamation: Current head e47e12f differs from pull request most recent head 280da69

Please upload reports for the commit 280da69 to get more accurate results.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           fix-config-desync     #609      +/-   ##
=====================================================
+ Coverage              95.93%   95.94%   +0.01%     
=====================================================
  Files                     24       24              
  Lines                   3638     3651      +13     
  Branches                 736      735       -1     
=====================================================
+ Hits                    3490     3503      +13     
  Misses                    84       84              
  Partials                  64       64              

see 1 file with indirect coverage changes

codecov[bot] avatar Jun 19 '24 09:06 codecov[bot]

Turns out our data saving steps have some unexpected bugs. Opened #614 to deal with them.

irm-codebase avatar Jun 22 '24 21:06 irm-codebase

Converting to draft because #614 is a blocker to this PR.

irm-codebase avatar Jun 24 '24 17:06 irm-codebase