ggthemeassist icon indicating copy to clipboard operation
ggthemeassist copied to clipboard

Go for the browserViewer()?

Open ottlngr opened this issue 8 years ago • 7 comments

Because many issues are more or less related to the available size on the screen, maybe leaving the RStudio window to run the add-in in a browser is worth a try? (Nearly) the full screen would be available to create a real ggThemeAssist monster!

ottlngr avatar Mar 12 '16 10:03 ottlngr

I personally preferred the dialogViewer. But we could also go for the panelViewer, which also has a button to switch to the browser.

calligross avatar Mar 12 '16 10:03 calligross

I think it will look horrible in the paneViewer because it's simply way too small... You would start the add-in and get a mess in the paneViewer just to switch to a browser from the button in the paneViewer... Why not directly to the browser?

ggThemeAssist grew out the dialogViewer() quite quicky ;)

ottlngr avatar Mar 12 '16 10:03 ottlngr

I don't like the browser, cause when you click done/cancel, the shiny gadget is still shown.

I think before going for the browser, we should streamline the UI. But let's also see what other users opinion is.

calligross avatar Mar 12 '16 11:03 calligross

It's indeed impossible to close the browser with the 'Done' button...

ottlngr avatar Mar 12 '16 11:03 ottlngr

It might be possible using some JavaScript. I will try to figure this out...

ottlngr avatar Mar 12 '16 11:03 ottlngr

Huh, I also thought browserViewer would be the better choice, and I didn't even notice the closing issue since I always ⌘+W out of tabs anyway, but I see how this is a downside.

jemus42 avatar Mar 12 '16 13:03 jemus42

According to statements of some RStudio guys it is also impossible to close the browser using some JS.

ottlngr avatar Mar 13 '16 23:03 ottlngr