OMOP2OBO icon indicating copy to clipboard operation
OMOP2OBO copied to clipboard

Published 20 hours ago • verified publisher icon callahantiff

Move main.py into package and add vanity CLI

Open cthoyt opened this issue 3 years ago • 4 comments

Closes #56

This PR does the following:

  1. Moves main.py into the main package hierarchy. My personal preference is to name the file cli.py, but I'll leave this as an option to you
  2. Adds a vanity CLI using python entrypings (see changes in setup.py)
  3. Updates documentation in README.rst and jupyter notebook
  4. Bonus: add __main__.py for usage as python -m omop2obo as well as docs in the top explaining what's going on

Happy ontologizing!

cthoyt avatar Jan 17 '21 01:01 cthoyt

@cthoyt - Thanks so much for doing this. I've got some big deadlines this week and will work on merging your changes this weekend.

callahantiff avatar Jan 19 '21 18:01 callahantiff

@callahantiff no rush! good luck

cthoyt avatar Jan 19 '21 18:01 cthoyt

Greetings from the future @callahantiff

congrats on the 1.0 release, I just updated the code vs the main branch and this could still be merged if you want

cthoyt avatar Nov 09 '21 13:11 cthoyt

Thanks so much, @cthoyt!! - I am so sorry that I have not included the awesome work you did in release v1.0.0. I had to rush this release and it needed to follow a specific format for a downstream application. I am currently working on v2.0.0 and am planning on including the awesome change you made in that. I hope that's OK!

callahantiff avatar Nov 11 '21 02:11 callahantiff