OMOP2OBO icon indicating copy to clipboard operation
OMOP2OBO copied to clipboard

Published 20 hours ago • verified publisher icon callahantiff

Add vanity CLI

Open cthoyt opened this issue 3 years ago • 4 comments

If the main.py were included in the source code hierarchy, the python entrypoints in setuptools could be used ot make a vanity cli called omop2obo along with installation of the code. This would make it much more extensible for others since they wouldn't have to know where the code itself was. Would you be willing to accept a PR for this?

cthoyt avatar Jan 15 '21 18:01 cthoyt

Hey @cthoyt! The functionality you are describing sounds like a great. Thanks for offering to do this, I'd be happy to review a PR 😄

callahantiff avatar Jan 17 '21 01:01 callahantiff

I have some experience with CLIs, as well as packaging and releasing stuff on PyPi. I don't know how much extra bandwidth I have, but this is something I could possibly help with.

@cthoyt What is a vanity CLI? Is that just a figure of speech, or a particular type of CLI?

joeflack4 avatar Feb 24 '22 16:02 joeflack4

This is when you use Python entrypoints to make a nice CLI command available in the shell like obo2omop - this is not a standard phrase but I think it's appropriate since it wraps what would otherwise be python -m obo2omop. Please note I already sent a PR that solves this issue, linked just above your comment (or here #57)

more info on how I think about this on my blog: https://cthoyt.com/2020/06/11/click.html

cthoyt avatar Mar 02 '22 10:03 cthoyt

Ah ok, that's pretty cool. I'll give that a read.

joeflack4 avatar Mar 02 '22 13:03 joeflack4