gentle-glow-onyx-boox icon indicating copy to clipboard operation
gentle-glow-onyx-boox copied to clipboard

Published 20 hours ago • verified publisher icon calin-darie

Onyx Slider is not a preset: reflect that in both code and UI

Open calin-darie opened this issue 3 years ago • 0 comments

  • [x] spec ready for first development
  • [x] technical tasks defined
  • [ ] first app store release
  • [ ] tested and approved in app store

Onyx Slider is special: it's not a preset, it just shows you the last setting that was made outside GG. Its purpose is twofold: 1. See what the GG equivalent of your current Onyx sliders is, and 2. Have a way to restore your last Onyx slider setting, because using GG results in settings outside of Onyx slider's available increments and these settings are presented by Onyx as light on, slider at position zero.

If there were a way to hide the Onyx native sliders, it would make sense to remove the Onyx Slider option completely.

Spec: Replace Onyx Slider radio button with a button labeled "Restore Onyx sliders"

Implementation detail:

  • remove boolean isOnyxSlider from isForOnyxCompatibility from LightConfiguration.
  • allow no selection in MutuallyExclusiveChoice<LightConfiguration>

calin-darie avatar Dec 10 '21 11:12 calin-darie