linux-gui-legacy icon indicating copy to clipboard operation
linux-gui-legacy copied to clipboard

.desktop File Creation Instructions Violate the Desktop Menu Specification.

Open Gambloide opened this issue 3 years ago • 1 comments

Description The Create .desktop file section of the README.md does not adhere to the Desktop Menu Specification and fails validation:

$ desktop-file-validate protonvpn-gui.desktop
protonvpn-gui.desktop: error: value "False" for boolean key "Terminal" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"
protonvpn-gui.desktop: error: value "Utility;GUI;Network;VPN" for key "Categories" in group "Desktop Entry" contains an unregistered value "GUI"; values extending the format should start with "X-"
protonvpn-gui.desktop: hint: value "Utility;GUI;Network;VPN" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu
protonvpn-gui.desktop: error: value "Utility;GUI;Network;VPN" for key "Categories" in group "Desktop Entry" contains an unregistered value "VPN"; values extending the format should start with "X-"
  1. False should be false
  2. invalid categories should either be
    1. replaced with valid replacements
    2. removed
    3. indicated as extensions by prefixing them with "X-"

Working Example Passing Validation:

Terminal=false
Categories=Utility;X-GUI;Network;X-VPN

To Reproduce Follow the installation instructions for Fedora from https://github.com/ProtonVPN/linux-gui/blob/master/README.md

Desktop:

  • OS: Fedora 32
  • Shell: Gnome 3.36

Gambloide avatar Aug 30 '20 18:08 Gambloide

Hi @Gambloide 😊

Thanks for bringing this up. This is something that is very helpful. This should be fixed in the near future.

calexandru2018 avatar Aug 30 '20 19:08 calexandru2018