better-phpunit icon indicating copy to clipboard operation
better-phpunit copied to clipboard

Load xmlConfigFilePath when running in Better PHPUnit in docker conta…

Open DaanGeurts opened this issue 5 years ago • 4 comments

When running Better PHPUnit in a Docker container it respects the configuration override by xmlConfigFilePath

DaanGeurts avatar Feb 14 '20 15:02 DaanGeurts

Thanks for this. Any chance of providing a test?

I personally don't really use Docker so it always makes me nervous merging stuff I can't easily verify works.

calebporzio avatar Feb 15 '20 06:02 calebporzio

I'm on it!

DaanGeurts avatar Feb 15 '20 06:02 DaanGeurts

woohoo!

calebporzio avatar Feb 15 '20 06:02 calebporzio

Hi @calebporzio, is there any reason why Better PHPUnit doesn't append the configuration settings when running the full suite?

if (this.runFullSuite) {
    this.lastOutput = `${this.binary}${suiteSuffix}${this.suffix}`
} else if (this.runFile) {
     this.lastOutput = `${this.binary} ${this.file}${this.configuration}${this.suffix}`;
} else {
    this.lastOutput = `${this.binary} ${this.file}${this.filter}${this.configuration}${this.suffix}`;
}

DaanGeurts avatar Feb 17 '20 09:02 DaanGeurts