bap icon indicating copy to clipboard operation
bap copied to clipboard

rapidfuzz not present in bap Python package dependencies

Open aksarkar opened this issue 1 year ago • 2 comments

https://github.com/caleblareau/bap/blob/44061cdcc16d60d6a757d518d55b4dfe66afb436/setup.py#L7

This lead to a missing dependency in our internally built conda package metadata that wasn't discovered until runtime.

aksarkar avatar Apr 21 '23 18:04 aksarkar

thanks! is the fix as simple as adding this to the line that you noted?

caleblareau avatar Apr 27 '23 18:04 caleblareau

Yes, that should fix the issue.

The issue also affects the installation instructions given in the wiki, since pip install bap-atac does not pull in rapidfuzz either, and then bap-barcode fails silently.

aksarkar avatar May 02 '23 22:05 aksarkar