SimpleAuth icon indicating copy to clipboard operation
SimpleAuth copied to clipboard

SimpleAuthTwitterProvider not showing UIActionSheet on iPad2 iOS 8.1

Open MaximKeegan opened this issue 11 years ago • 5 comments

- (void)presentActionSheet:(UIActionSheet *)actionSheet {
    UIWindow *window = [UIWindow SimpleAuth_mainWindow];
    [actionSheet showInView:window];
}

Not working on iOS8. It doesn't work because Apple changed internal implementation of UIActionSheet. Can you please use UIAlertController with a preferredStyle of UIAlertControllerStyleActionSheet?

MaximKeegan avatar Nov 25 '14 09:11 MaximKeegan

Shouldn't showInView: still work? I don't want to move to UIAlertcontroller just yet since that I'd have to require iOS 8.

calebd avatar Nov 25 '14 15:11 calebd

I have tested showInView: on iPad iOS8.1 and it didn't work. Does not show UIActionSheet at all. But on iPhone it works well. You can see #79. I have made hotfix for my app.

MaximKeegan avatar Nov 25 '14 20:11 MaximKeegan

Can this be closed?

dkhamsing avatar Mar 31 '15 21:03 dkhamsing

@dkhamsing Maybe? I think I would rather deprecate using sheets for this (since they got weird in 8) and switch to a view controller. What do you think about that?

calebd avatar Mar 31 '15 22:03 calebd

Ah I see.. yeah makes sense

dkhamsing avatar Mar 31 '15 22:03 dkhamsing