automata icon indicating copy to clipboard operation
automata copied to clipboard

Add support for character classes `[...]`

Open StefanosChaliasos opened this issue 10 months ago • 8 comments

Fixes #249

It also makes the quantifiers more expressive:

I.e., now it supports: {,4}, {4}, {1,3}, {1,} instead of just {1,3} and {1,}

StefanosChaliasos avatar Mar 06 '25 09:03 StefanosChaliasos

@StefanosChaliasos thanks for this contribution! A bit busy today but I'll try to review this at some point in the evening.

eliotwrobson avatar Mar 06 '25 16:03 eliotwrobson

Coverage Status

coverage: 98.008% (-1.6%) from 99.613% when pulling df53edcc873dadb2586facfa65cba75dbf0eb063 on StefanosChaliasos:add-support-for-charclass into 1bdf9b7c94f3681976b41165044c626a768fb560 on caleb531:develop.

coveralls avatar Mar 06 '25 16:03 coveralls

Will go over everything tomorrow. Thanks a lot for the feedback.

StefanosChaliasos avatar Mar 06 '25 19:03 StefanosChaliasos

I did some more changes, can you review the new ones. Basically I added support for shorthand (e.g., '\d') and I tokenised whitespace. I need to add more tests and polish the code. I'll change the PR as a draft until done.

StefanosChaliasos avatar Mar 07 '25 08:03 StefanosChaliasos

Hey, @StefanosChaliasos! I left some additional comments on the PR—apologies if they seem nitpicky, but just wanting to maintain solid code quality and consistency for this project.

caleb531 avatar Mar 14 '25 20:03 caleb531

Thanks for the review, I will address the comments once I find some time

StefanosChaliasos avatar Mar 14 '25 21:03 StefanosChaliasos

Thanks for the additional comments, will fix everything by the end of the week. Got busy with other stuff :)

StefanosChaliasos avatar May 07 '25 05:05 StefanosChaliasos

@StefanosChaliasos just want to check in briefly since this will now require a rebase on the develop branch because of some changes that have been made on our end. The comments I made earlier are relatively minor, so let me know if you'd like any help landing this. I think we want to cut a new release before too long so it would be awesome to have these changes included 👍🏽

eliotwrobson avatar Jun 14 '25 17:06 eliotwrobson