cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Fix operators for number

Open hariombalhara opened this issue 1 year ago • 1 comments

What does this PR do?

Fixes # (issue)

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

hariombalhara avatar May 29 '23 13:05 hariombalhara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 10:42am
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 10:42am
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 10:42am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 10:42am
qa ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 10:42am
ui ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2023 10:42am

vercel[bot] avatar May 29 '23 13:05 vercel[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 30 '23 00:06 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Jul 07 '23 00:07 github-actions[bot]

Thank you for following the naming conventions! 🙏

github-actions[bot] avatar Jul 10 '23 09:07 github-actions[bot]

It's an important PR. Will work on it one high priority things are done

hariombalhara avatar Jul 10 '23 09:07 hariombalhara

🤖 Meticulous spotted visual differences in 53 of 174 screens tested: view and approve differences detected.

Last updated for commit ac26aab. This comment will update as new commits are pushed.

alwaysmeticulous[bot] avatar Aug 03 '23 11:08 alwaysmeticulous[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 155.33 KB (🟡 +580 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 537.51 KB 692.84 KB 197.95% (🟡 +5.36%)
/settings/admin/users/[id]/edit 384.92 KB 540.25 KB 154.36% (🟡 +13.06%)
/settings/admin/users/add 384.59 KB 539.92 KB 154.26% (🟡 +13.06%)
/settings/my-account/general 381.48 KB 536.81 KB 153.37% (🟡 +12.88%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Aug 03 '23 11:08 github-actions[bot]

Current Playwright Test Results Summary

✅ 120 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/23/2023 10:49:09am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ac26aab07a80f06e36a359ca4ceae7106360fd12

Started: 08/23/2023 10:47:13am UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1Initial Attempt
0% (0) 0 / 243 runs
failed over last 7 days
3.29% (8) 8 / 243 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 1Initial Attempt
2.82% (7) 7 / 248 runs
failed over last 7 days
6.45% (16) 16 / 248 runs
flaked over last 7 days
Stripe integration Paid booking should be able to be rescheduled
Retry 1Initial Attempt
2.03% (5) 5 / 246 runs
failed over last 7 days
10.57% (26) 26 / 246 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
2.87% (7) 7 / 244 runs
failed over last 7 days
96.72% (236) 236 / 244 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar Aug 03 '23 15:08 deploysentinel[bot]

Thanks for the review @ologbonowiwi. Accepted your suggestions 🙏

hariombalhara avatar Aug 16 '23 08:08 hariombalhara