cal.com
cal.com copied to clipboard
Fix operators for number
What does this PR do?
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
- Bug fix (non-breaking change which fixes an issue)
- Chore (refactoring code, technical debt, workflow improvements)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update
How should this be tested?
- [ ] Test A
- [ ] Test B
Checklist
- I haven't read the contributing guide
- My code doesn't follow the style guidelines of this project
- I haven't performed a self-review of my own code and corrected any misspellings
- I haven't commented my code, particularly in hard-to-understand areas
- I haven't checked if my PR needs changes to the documentation
- I haven't checked if my changes generate no new warnings
- I haven't added tests that prove my fix is effective or that my feature works
- I haven't checked if new and existing unit tests pass locally with my changes
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 31, 2023 0:35am |
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 31, 2023 0:35am |
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ⬜️ Ignored (Inspect) | May 31, 2023 0:35am |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Ten Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/[user]/book |
254.97 KB |
406.16 KB | 116.05% (🟢 -0.14%) |
/apps/[slug]/[...pages] |
459.24 KB |
610.43 KB | 174.41% (🟡 +0.26%) |
/auth/setup |
174.9 KB |
326.09 KB | 93.17% (🟡 +0.16%) |
/d/[link]/book |
254.62 KB |
405.81 KB | 115.95% (🟢 -0.15%) |
/event-types/[type] |
479.62 KB |
630.81 KB | 180.23% (🟡 +0.19%) |
/getting-started/[[...step]] |
426.28 KB |
577.47 KB | 164.99% (🟢 -0.22%) |
/new-booker/[user]/[type] |
290.24 KB |
441.42 KB | 126.12% (🟢 -0.14%) |
/new-booker/team/[slug]/[type] |
290.24 KB |
441.43 KB | 126.12% (🟢 -0.14%) |
/settings/my-account/calendars |
252.55 KB |
403.74 KB | 115.35% (🟢 -0.23%) |
/team/[slug]/book |
254.62 KB |
405.81 KB | 115.95% (🟢 -0.14%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
CAL-1806 Routing Form: number comparison operators seem to operate on strings instead of numbers
Greater than operator b/w 500 and 1000 considers 500 as bigger.
https://calcominc.slack.com/archives/C050R8Z2RP0/p1685143897762489
No failed tests 🎉