cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Tests: Automated TypeScript build check for a sample react App using @calcom/embed-react

Open hariombalhara opened this issue 2 years ago • 4 comments

What does this PR do?

Closes #9091

It would allow us to solve these problems

  • Easily update all code sandboxes.
  • Codesandboxes would be reviewable now
  • Verify that the TypeScript code in them builds correctly
  • We would have list of all working embed examples in one place.

Type of change

  • Test (non-breaking change which fixes an issue)

Observations

  • If the motive is to find out if type definitions are correctly specified in package.json, then a single demo app that imports embed-react should be able to test it.
    • For testing the types of supported instructions(like ui, on, off), when we write unit tests in TypeScript, that would automatically be verified.
  • If the motive is to just find out if the file specified at packageJson.types exist then we can do a check after build if it exists.
  • Codesandbox doesn't allow a particular folder or a package in the monorepo to be linked to a Codesandbox.
    • Connecting the entire repo to codesandbox makes it slow and people don't quickly fork different variations of codesandboxes the way it's possible right now

How should this be tested?

  • [ ] Test A
  • [ ] Test B

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

hariombalhara avatar May 26 '23 13:05 hariombalhara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ❌ Failed (Inspect) May 29, 2023 5:42am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 5:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
api ⬜️ Ignored (Inspect) Visit Preview May 29, 2023 5:42am

vercel[bot] avatar May 26 '23 13:05 vercel[bot]

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
[email protected] None +0 typescript-bot

socket-security[bot] avatar May 26 '23 13:05 socket-security[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 256.2 KB 407.15 KB 116.33% (🟡 +0.14%)
/apps/[slug]/[...pages] 457.86 KB 608.81 KB 173.95% (🟢 -0.25%)
/auth/setup 174.22 KB 325.17 KB 92.91% (🟢 -0.16%)
/d/[link]/book 255.84 KB 406.79 KB 116.23% (🟡 +0.14%)
/event-types/[type] 479.43 KB 630.38 KB 180.11% (🟢 -0.19%)
/getting-started/[[...step]] 426.91 KB 577.86 KB 165.10% (🟡 +0.23%)
/new-booker/[user]/[type] 291.42 KB 442.37 KB 126.39% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 291.42 KB 442.37 KB 126.39% (🟡 +0.14%)
/settings/my-account/calendars 253.07 KB 404.02 KB 115.43% (🟡 +0.24%)
/team/[slug]/book 255.85 KB 406.8 KB 116.23% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 26 '23 14:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 104 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/26/2023 02:17:14pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: e7d633e4a4a17f000d50a135cb4448e9d4e0b952

Started: 05/26/2023 02:07:19pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
3.05% (13) 13 / 426 runs
failed over last 7 days
28.87% (123) 123 / 426 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 435 runs
failed over last 7 days
86.90% (378) 378 / 435 runs
flaked over last 7 days
Booking with Seats -- old-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 431 runs
failed over last 7 days
20.88% (90) 90 / 431 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2Retry 1Initial Attempt
3.57% (3) 3 / 84 runs
failed over last 7 days
47.62% (40) 40 / 84 runs
flaked over last 7 days

📄   apps/web/playwright/app-store.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
App Store - Authed Installed Apps - Navigation
Retry 1Initial Attempt
0.22% (1) 1 / 457 run
failed over last 7 days
0.22% (1) 1 / 457 run
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 26 '23 14:05 deploysentinel[bot]