cal.com
cal.com copied to clipboard
fix: upgrade btn bug
What does this PR do?
Fixes https://github.com/calcom/cal.com/issues/9102
Download button is working fine and only visible when user has teams plan. the upgrade button should render in case user is not part of any active team which was not happening https://calendso.slack.com/archives/C01NXDSRY9W/p1684959944326289?thread_ts=1684958912.389019&cid=C01NXDSRY9W
Environment: Staging(main branch) / Production
Type of change
- Bug fix (non-breaking change which fixes an issue)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 29, 2023 7:39pm |
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 29, 2023 7:39pm |
| ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 29, 2023 7:39pm |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/apps/[slug]/[...pages] |
458.86 KB |
609.81 KB | 174.23% (🟡 +0.25%) |
/auth/setup |
174.78 KB |
325.73 KB | 93.07% (🟡 +0.16%) |
/bookings/[status] |
342.12 KB |
493.07 KB | 140.88% (🟡 +0.33%) |
/event-types/[type] |
480.08 KB |
631.04 KB | 180.30% (🟡 +0.18%) |
/getting-started/[[...step]] |
426.17 KB |
577.13 KB | 164.89% (🟢 -0.22%) |
/settings/my-account/calendars |
252.26 KB |
403.21 KB | 115.20% (🟢 -0.23%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
Current Playwright Test Results Summary
✅ 97 Passing - ❌ 1 Failing - ⚠️ 2 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 05/29/2023 08:11:26pm UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: 9a5ad025dc3e284e5294ee89f8fcc20d3ec9e9a6
Started: 05/29/2023 07:57:46pm UTC
❌ Failures
📄 apps/web/playwright/login.e2e.ts • 1 Failure
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt Error: page.waitForURL: Timeout 15000ms exceeded....
|
8.22% (30)30 / 365 runsfailed over last 7 days |
0.55% (2)2 / 365 runsflaked over last 7 days |
⚠️ Flakes
📄 apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 2 • Retry 1 • Initial Attempt |
2.73% (10)10 / 366 runsfailed over last 7 days |
30.60% (112)112 / 366 runsflaked over last 7 days |
📄 apps/web/playwright/booking-seats.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1 • Initial Attempt |
0% (0)0 / 378 runsfailed over last 7 days |
88.10% (333)333 / 378 runsflaked over last 7 days |
can you also fix the border? its not supposed to be border only I think you need to add border-subtle