cal.com
cal.com copied to clipboard
feat: email verification
What does this PR do?
Implements email verification controlled by a feature flag
Loom: https://www.loom.com/share/0b0b9302a0e8499fad1d6444b013337c
Environment: Staging(main branch) / Production
Type of change
- New feature (non-breaking change which adds functionality)
How should this be tested?
- [ ] Login as ADMIN
- [ ] Enable Feature flag
- [ ] Verify your account
- [ ] create a new account
- [ ] verify flow works as expected
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| cal | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 7, 2023 2:24am |
| web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 7, 2023 2:24am |
| website | ❌ Failed (Inspect) | Jun 7, 2023 2:24am |
2 Ignored Deployments
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| api | ⬜️ Ignored (Inspect) | Visit Preview | Jun 7, 2023 2:24am | |
| ui | ⬜️ Ignored (Inspect) | Visit Preview | Jun 7, 2023 2:24am |
📦 Next.js Bundle Analysis for @calcom/web
This analysis was generated by the Next.js Bundle Analysis action. 🤖
New Page Added
The following page was added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/auth/verify-email |
89.06 KB |
239.85 KB | 68.53% |
Nine Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/[user]/book |
252.42 KB |
403.21 KB | 115.20% (🟢 -0.27%) |
/apps/installed/[category] |
276.49 KB |
427.28 KB | 122.08% (🟢 -0.14%) |
/d/[link]/book |
252.07 KB |
402.86 KB | 115.10% (🟢 -0.27%) |
/getting-started/[[...step]] |
424.71 KB |
575.5 KB | 164.43% (🟢 -0.22%) |
/new-booker/[user]/[type] |
288.12 KB |
438.91 KB | 125.40% (🟢 -0.27%) |
/new-booker/d/[link]/[slug] |
288.12 KB |
438.91 KB | 125.40% (🟢 -0.27%) |
/new-booker/team/[slug]/[type] |
288.12 KB |
438.91 KB | 125.40% (🟢 -0.27%) |
/settings/my-account/calendars |
251.06 KB |
401.85 KB | 114.81% (🟢 -0.17%) |
/team/[slug]/book |
252.07 KB |
402.86 KB | 115.10% (🟢 -0.27%) |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-
Current Playwright Test Results Summary
✅ 24 Passing - ⚠️ 1 Flaky
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 06/07/2023 07:27:01am UTC)
Run Details
Running Workflow PR Update on Github Actions
Commit: 1bea5be01547cb69e6f76c369ce5ddb8a6a8436b
Started: 06/07/2023 07:24:58am UTC
⚠️ Flakes
📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests -- new-booker Should display request reschedule send on bookings/cancelled
Retry 1 • Initial Attempt |
0% (0)0 / 336 runsfailed over last 7 days |
0.30% (1)1 / 336 runflaked over last 7 days |
I am not sure if we are following this approach at other places, but we should delete the tokens once they are used(e.g. after email has been verified). There might be a separate cron to cleanup expired tokens.
@sean-brydon If it is the wrong token, should we not show a proper page? Right now, it only shows the json body. Let me know your thoughts.
@sean-brydon If it is the wrong token, should we not show a proper page? Right now, it only shows the json body. Let me know your thoughts.
You're absolutely right - this is something i missed. Would you mind creating an issue on the back of what you have found while writing the test?