cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Changed 1 Seats available to 1 Seat available for all languages

Open velumuruganr opened this issue 1 year ago • 10 comments

What does this PR do?

Changed the 1 Seats available to 1 Seat available for all languages. Added a 'count' parameter in the 't' function to get the relevant text using the i18next plurals. /claim #9063

Fixes #9063

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshot 2023-05-23 172555

velumuruganr avatar May 23 '23 12:05 velumuruganr

@velumuruganr is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 23 '23 12:05 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 9:17am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 9:17am

vercel[bot] avatar May 23 '23 12:05 vercel[bot]

great work that was fast!

PeerRich avatar May 23 '23 12:05 PeerRich

Did a great job @velumuruganr . I was almost committing my changes when I saw your PR.

gurkiratz avatar May 23 '23 12:05 gurkiratz

@velumuruganr, please fix lint errors by running yarn fix:lint.

sanudutta45 avatar May 23 '23 12:05 sanudutta45

I am very happy to share that this is my first ever open-source contribution. Thank you for the opportunity.

velumuruganr avatar May 23 '23 12:05 velumuruganr

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 256.19 KB 407.13 KB 116.32% (🟡 +0.15%)
/apps/[slug]/[...pages] 457.85 KB 608.79 KB 173.94% (🟢 -0.25%)
/auth/setup 174.22 KB 325.17 KB 92.90% (🟢 -0.16%)
/d/[link]/book 255.83 KB 406.78 KB 116.22% (🟡 +0.15%)
/event-types/[type] 479.41 KB 630.35 KB 180.10% (🟢 -0.19%)
/getting-started/[[...step]] 426.89 KB 577.84 KB 165.10% (🟡 +0.22%)
/new-booker/[user]/[type] 291.41 KB 442.35 KB 126.39% (🟡 +0.14%)
/new-booker/team/[slug]/[type] 291.41 KB 442.36 KB 126.39% (🟡 +0.14%)
/settings/my-account/calendars 253.06 KB 404 KB 115.43% (🟡 +0.23%)
/team/[slug]/book 255.83 KB 406.78 KB 116.22% (🟡 +0.15%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 23 '23 12:05 github-actions[bot]

Can anyone help me. My RAM goes 100%(8GB) when I run the 'yarn lint:fix' command. Anyone have idea of why this happens?

velumuruganr avatar May 23 '23 13:05 velumuruganr

I am very happy to share that this is my first ever open-source contribution. Thank you for the opportunity.

@velumuruganr that's amazing, I was also working on this but great to see you had such a great start to open source 🤗

shawshankkumar avatar May 23 '23 13:05 shawshankkumar

Can anyone help me. My RAM goes 100%(8GB) when I run the 'yarn lint:fix' command. Anyone have idea of why this happens?

Can you send a screenshot of what's happening? I can try to help

shawshankkumar avatar May 23 '23 13:05 shawshankkumar