cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix: use the correct locale for event name in booking detail page

Open G3root opened this issue 1 year ago • 3 comments

What does this PR do?

previously event name saved in the db is used for booking detail page as event title, which is in the locale of the organizer. this change was introduced in #7888 to prevent "Nameless" replacing attendee while cancelling a booking. as we are now not deleting the attendees #8203 , above mentioned issue won't happen. this PR aims to fallback to eventName for event title, which also fixes the wrong attendee locale issue.

before:

Screenshot 2023-05-23 at 12-35-45 Your booking has been confirmed Cal com

after:

Screenshot 2023-05-23 at 12-35-14 Your booking has been confirmed Cal com

Type of change

  • Bug fix (non-breaking change which fixes an issue)

G3root avatar May 23 '23 07:05 G3root

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 8:16am
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 8:16am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 8:16am

vercel[bot] avatar May 23 '23 07:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.76 KB 407.04 KB 116.30% (🟡 +0.14%)
/apps/[slug]/[...pages] 459.19 KB 610.47 KB 174.42% (🟢 -0.25%)
/auth/setup 174.55 KB 325.84 KB 93.10% (🟢 -0.16%)
/d/[link]/book 255.41 KB 406.69 KB 116.20% (🟡 +0.14%)
/event-types/[type] 479.19 KB 630.48 KB 180.14% (🟢 -0.19%)
/getting-started/[[...step]] 427.27 KB 578.56 KB 165.30% (🟡 +0.23%)
/new-booker/[user]/[type] 290.95 KB 442.24 KB 126.35% (🟡 +0.15%)
/new-booker/d/[link]/[slug] 290.95 KB 442.24 KB 126.35% (🟡 +0.15%)
/new-booker/team/[slug]/[type] 290.96 KB 442.24 KB 126.35% (🟡 +0.15%)
/settings/my-account/calendars 253.53 KB 404.81 KB 115.66% (🟡 +0.23%)
/team/[slug]/book 255.41 KB 406.69 KB 116.20% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 23 '23 07:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 106 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 06/05/2023 08:22:56am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: f5e3e003425a3f80baaab85c767f1b83fac0dd0a

Started: 06/05/2023 08:20:57am UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download
Retry 1Initial Attempt
0% (0) 0 / 213 runs
failed over last 7 days
12.68% (27) 27 / 213 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 1Initial Attempt
3.48% (7) 7 / 201 runs
failed over last 7 days
93.53% (188) 188 / 201 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 23 '23 07:05 deploysentinel[bot]

also fixes #9292

G3root avatar Jun 05 '23 08:06 G3root