cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

fix/replacing bookingAttendees for bookingUid

Open alannnc opened this issue 1 year ago • 4 comments

What does this PR do?

  • Replace bookingAttendees length for bookingUid, if required we fetch booking attendees on server.

Environment: Staging(main branch)

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

alannnc avatar May 19 '23 18:05 alannnc

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 6:59pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 6:59pm

vercel[bot] avatar May 19 '23 18:05 vercel[bot]

@alannnc What is the purpose of this refactor? Does it solve any bug?

roae avatar May 19 '23 19:05 roae

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 19 '23 19:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 114 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/19/2023 07:14:28pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0deca26703373db14096578a2f4a8b28c33dc93a

Started: 05/19/2023 07:04:09pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 265 runs
failed over last 7 days
83.77% (222) 222 / 265 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 19 '23 19:05 deploysentinel[bot]