cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

dark icons fix

Open saurabbot opened this issue 2 years ago • 3 comments

What does this PR do?

Fixes #8966 in the /settings/admin/apps/conferencing the icons werent visible cuz of the dark mode.

Fixes # (issue)

Screenshot 2023-05-18 at 7 13 54 PM Screenshot 2023-05-19 at 1 07 38 PM Screenshot 2023-05-19 at 1 12 24 PM Screenshot 2023-05-19 at 1 12 35 PM

ran the project after changes works fine

Checklist

saurabbot avatar May 18 '23 13:05 saurabbot

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 10:51am

vercel[bot] avatar May 18 '23 13:05 vercel[bot]

@firefox292 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 18 '23 13:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/book 255.7 KB 406.65 KB 116.19% (🟢 -0.15%)
/apps/[slug]/[...pages] 458.73 KB 609.68 KB 174.19% (🟡 +0.25%)
/auth/setup 174.8 KB 325.75 KB 93.07% (🟡 +0.17%)
/d/[link]/book 255.34 KB 406.29 KB 116.08% (🟢 -0.14%)
/event-types/[type] 480.07 KB 631.02 KB 180.29% (🟡 +0.18%)
/getting-started/[[...step]] 426.13 KB 577.08 KB 164.88% (🟢 -0.23%)
/new-booker/[user]/[type] 290.92 KB 441.88 KB 126.25% (🟢 -0.14%)
/new-booker/team/[slug]/[type] 290.93 KB 441.88 KB 126.25% (🟢 -0.14%)
/settings/my-account/calendars 252.25 KB 403.21 KB 115.20% (🟢 -0.23%)
/team/[slug]/book 255.35 KB 406.3 KB 116.08% (🟢 -0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 18 '23 13:05 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 30 '23 00:06 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Jul 07 '23 00:07 github-actions[bot]

@hariombalhara please re-review; reopening as the comments look encouraging

emrysal avatar Jul 26 '23 00:07 emrysal

Thank you for following the naming conventions! 🙏

github-actions[bot] avatar Jul 26 '23 00:07 github-actions[bot]

hey @saurabbot can you look into the merge conflict?

PeerRich avatar Jul 26 '23 15:07 PeerRich

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Aug 10 '23 00:08 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Aug 18 '23 00:08 github-actions[bot]