cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

[CAL-1718] Code Cleanup: All accounts are PRO now, so remove isProOnly flag from App Store Apps

Open hariombalhara opened this issue 1 year ago • 12 comments

Screenshot 2023-05-18 at 11 56 35 AM

CAL-1718

hariombalhara avatar May 18 '23 06:05 hariombalhara

Hii @hariombalhara I am new to open source contribution and would like to work on this issue. Thank you

Sudhanshu10Sathawane avatar May 18 '23 07:05 Sudhanshu10Sathawane

So I just removed the lines of codes you mentioned above, I guess that was the requirement can you confirm it, should i request a PR now ?

Swapnil-2502 avatar May 18 '23 07:05 Swapnil-2502

It should be those lines in general. You should understand that logic and then test out that the flow is working now for apps installation.

hariombalhara avatar May 18 '23 07:05 hariombalhara

So actually when I run "yarn dev"

It gives me this error:

@calcom/web:dev: error - PrismaClientInitializationError: @calcom/web:dev: Invalid prisma.user.count() invocation: @calcom/web:dev: @calcom/web:dev: @calcom/web:dev: Can't reach database server at localhost:5450

What I might have done wrong ?

Swapnil-2502 avatar May 18 '23 08:05 Swapnil-2502

@Swapnil-2502 Try yarn dx command. You should have docker compose installed as well.

shivamklr avatar May 18 '23 08:05 shivamklr

@shivamklr I already have docker desktop installed but still "yarn dx" is not working.

Swapnil-2502 avatar May 18 '23 10:05 Swapnil-2502

@Swapnil-2502 u shld make sure that docker it running locally.

VinoV1999 avatar May 18 '23 16:05 VinoV1999

Docker is running locally.

But at VS code I am getting this error: Screenshot 2023-05-19 at 11 05 06 PM

And this is after yarn dx

Screenshot 2023-05-19 at 11 05 40 PM

Swapnil-2502 avatar May 19 '23 17:05 Swapnil-2502

@hariombalhara can I take this? This is my first contribution with the project. I have successfully setup the project in my local environment.

HeratPatel avatar May 19 '23 17:05 HeratPatel

@hariombalhara generated the PR (https://github.com/calcom/cal.com/pull/8996), please have a look.

HeratPatel avatar May 19 '23 18:05 HeratPatel

@Swapnil-2502 If you are still facing an issue with the repository setup, consider reaching out on Slack.

shivamklr avatar May 20 '23 10:05 shivamklr

Just got done one hour ago, thanks

Swapnil-2502 avatar May 20 '23 11:05 Swapnil-2502