fix: add exp in /meeting-tokens

[Udit-takkar]

What does this PR do?

Fixes https://github.com/calcom/cal.com/issues/8802

The issue was that the Cal video meeting URL would expire if someone rescheduled the meeting for a later time than the previously selected one.

exp denotes expiry timestamp https://docs.daily.co/reference/rest-api/rooms/set-room-config#exp.

Environment: Staging(main branch) / Production

Type of change

• Bug fix (non-breaking change which fixes an issue)

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2023 4:15pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2023 4:15pm

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 112 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/15/2023 04:33:04pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ffd45233181f12e7f479d95f2c2c693228f2f7e1

Started: 05/15/2023 04:19:54pm UTC

⚠️ Flakes

📄   apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user -- old-booker has at least 2 events Retry 1 • Initial Attempt	0% (0) 0 / 330 runs failed over last 7 days	3.33% (11) 11 / 330 runs flaked over last 7 days

---

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type Retry 2 • Retry 1 • Initial Attempt	5.11% (17) 17 / 333 runs failed over last 7 days	29.43% (98) 98 / 333 runs flaked over last 7 days

---

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted Retry 1 • Initial Attempt	0% (0) 0 / 339 runs failed over last 7 days	69.32% (235) 235 / 339 runs flaked over last 7 days

---

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link - Reporting and CSV Download Retry 1 • Initial Attempt	0.99% (2) 2 / 203 runs failed over last 7 days	3.94% (8) 8 / 203 runs flaked over last 7 days

---

View Detailed Build Results

---

[leog]

Changes look good :+1: although while testing, when rescheduling I get a new video link, in which case do we want to not expire old video link? @Udit-takkar just to understand the context

[Udit-takkar]

@leog earlier when i tested on friday. it generated the same url when meeting was rescheduled and it's expiry time was updated and same url was valid for that much time instead of getting expired.

But now that i test it again i also get a new meeting url and both of the urls ( earlier and new one) are valid till expiry time( i don't think we require old meeting url if we are getting a new one but both of them works till the new endTime). Although this still solves the bug as i get new meeting url which is valid till the new end Time and the url is also updated in the calendar integration.

[PeerRich]

IMO a new URL is even better

[leog]

@leog earlier when i tested on friday. it generated the same url when meeting was rescheduled and it's expiry time was updated and same url was valid for that much time instead of getting expired.

But now that i test it again i also get a new meeting url and both of the urls ( earlier and new one) are valid till expiry time( i don't think we require old meeting url if we are getting a new one but both of them works till the new endTime). Although this still solves the bug as i get new meeting url which is valid till the new end Time and the url is also updated in the calendar integration.

Ok, good to know @Udit-takkar, and agree with you @PeerRich. The changes are still a good improvement so it's good to merge from my POV