cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

Published 20 hours ago • verified publisher icon calcom

Make cancellationReason configurable using FormBuilder

Open hariombalhara opened this issue 2 years ago • 2 comments

Fixes #7780

TODO:

  • [ ] Merge #8671 first
  • [ ] Figure out UI.
    • I don't see a usecase of allowing to create user fields for cancellation form. So, we can show cancellationReason as part of a separate form in the Booking Questions, that won't have user fields support.

hariombalhara avatar May 11 '23 12:05 hariombalhara

CAL-1290 Make it necessary to enter a reason for canceling the appointment

Your new update makes it possible to require the reason to reschedule the event. Can you do the same for the reason of cancellation of an event? So far, this is still completely optional.

linear[bot] avatar May 11 '23 12:05 linear[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 1:16pm
api ❌ Failed (Inspect) Sep 14, 2023 1:16pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 1:16pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 1:16pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 1:16pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2023 1:16pm
qa ⬜️ Ignored (Inspect) Visit Preview Sep 14, 2023 1:16pm

vercel[bot] avatar May 11 '23 12:05 vercel[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Jun 21 '23 00:06 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Jun 29 '23 00:06 github-actions[bot]

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

github-actions[bot] avatar Jul 19 '23 16:07 github-actions[bot]

This PR is being marked as stale due to inactivity.

github-actions[bot] avatar Aug 10 '23 00:08 github-actions[bot]

This PR is being closed due to inactivity. Please reopen if work is intended to be continued.

github-actions[bot] avatar Aug 18 '23 00:08 github-actions[bot]

Current Playwright Test Results Summary

✅ 51 Passing - ❌ 13 Failing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/14/2023 01:17:46pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 16d3983dd234c1d335c4540843ef9cd1ad9bf290

Started: 09/14/2023 01:13:58pm UTC

❌ Failures

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 3 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

 3 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should be able to reschedule
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
2.06% (6) 6 / 291 runs
failed over last 7 days
96.22% (280) 280 / 291 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
1.72% (5) 5 / 290 runs
failed over last 7 days
10.34% (30) 30 / 290 runs
flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
2.41% (7) 7 / 291 runs
failed over last 7 days
13.75% (40) 40 / 291 runs
flaked over last 7 days
📄   apps/web/playwright/booking-seats.e2e.ts • 2 Failures

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats Multiple Attendees can book a seated event time slot
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
1.70% (5) 5 / 294 runs
failed over last 7 days
0% (0) 0 / 294 runs
flaked over last 7 days
Reschedule for booking with seats Should cancel with seats but event should be still accesible and with one less attendee/seat
Initial Attempt
Error: Test timeout of 60000ms exceeded. 
Test timeout of 60000ms exceeded.
0.34% (1) 1 / 294 run
failed over last 7 days
0% (0) 0 / 294 runs
flaked over last 7 days
📄   apps/web/playwright/booking-pages.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
free user cannot book same slot multiple times
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
1.70% (5) 5 / 294 runs
failed over last 7 days
0.34% (1) 1 / 294 run
flaked over last 7 days
pro user book an event first day in next month
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
1.70% (5) 5 / 294 runs
failed over last 7 days
0% (0) 0 / 294 runs
flaked over last 7 days
📄   apps/web/playwright/teams.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams Can create a booking for Collective EventType
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
2.05% (6) 6 / 293 runs
failed over last 7 days
0.34% (1) 1 / 293 run
flaked over last 7 days
Teams Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
2.05% (6) 6 / 293 runs
failed over last 7 days
0% (0) 0 / 293 runs
flaked over last 7 days
📄   apps/web/playwright/event-types.e2e.ts • 2 Failures

Top 1 Common Error Messages

Timed out 30000ms waiting for expect(received).toBeVisible()

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests user can add multiple organizer address
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
2.09% (6) 6 / 287 runs
failed over last 7 days
16.72% (48) 48 / 287 runs
flaked over last 7 days
Event Types tests user Different Locations Tests can add Attendee Phone Number location and book with it
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
1.73% (5) 5 / 289 runs
failed over last 7 days
6.57% (19) 19 / 289 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
1.71% (5) 5 / 292 runs
failed over last 7 days
9.93% (29) 29 / 292 runs
flaked over last 7 days
📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Can book a paid booking
Retry 2 • Retry 1 • Initial Attempt
Error: Timed out 30000ms waiting for expect(received).toBeVisible()... 
Timed out 30000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 30000ms
  - waiting for locator('[data-testid=success-page]')
  - waiting for locator('[data-testid=success-page]')
2.08% (6) 6 / 288 runs
failed over last 7 days
6.60% (19) 19 / 288 runs
flaked over last 7 days

View Detailed Build Results

deploysentinel[bot] avatar Aug 18 '23 16:08 deploysentinel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seventy-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 225.65 KB 381.16 KB 108.90% (🟡 +0.58%)
/[user]/[type]/embed 225.68 KB 381.19 KB 108.91% (🟡 +0.57%)
/apps 279.2 KB 434.7 KB 124.20% (🟡 +0.26%)
/apps/[slug] 297.12 KB 452.63 KB 129.32% (🟡 +0.26%)
/apps/[slug]/[...pages] 534.84 KB 690.34 KB 197.24% (🟡 +0.48%)
/apps/categories 240.65 KB 396.15 KB 113.19% (🟡 +0.25%)
/apps/categories/[category] 261.95 KB 417.46 KB 119.27% (🟡 +0.26%)
/apps/installed/[category] 260.16 KB 415.66 KB 118.76% (🟡 +0.26%)
/availability 375.13 KB 530.63 KB 151.61% (🟡 +0.26%)
/availability/[schedule] 342.49 KB 497.99 KB 142.28% (🟡 +0.26%)
/availability/troubleshoot 241.33 KB 396.83 KB 113.38% (🟡 +0.26%)
/booking/[uid] 196.12 KB 351.63 KB 100.46% (🟡 +4.69%)
/bookings/[status] 333.27 KB 488.77 KB 139.65% (🟡 +0.51%)
/d/[link]/[slug] 225.64 KB 381.15 KB 108.90% (🟡 +0.57%)
/event-types 518.53 KB 674.03 KB 192.58% (🟡 +0.47%)
/event-types/[type] 371.31 KB 526.82 KB 150.52% (🟡 +0.28%)
/getting-started/[[...step]] 386.6 KB 542.1 KB 154.89% (🟢 -0.26%)
/insights 459.99 KB 615.49 KB 175.86% (🟡 +0.26%)
/more 240.28 KB 395.78 KB 113.08% (🟡 +0.26%)
/org/[orgSlug]/[user]/[type] 225.81 KB 381.32 KB 108.95% (🟡 +0.57%)
/org/[orgSlug]/[user]/[type]/embed 225.84 KB 381.34 KB 108.96% (🟡 +0.57%)
/org/[orgSlug]/team/[slug]/[type] 225.68 KB 381.18 KB 108.91% (🟡 +0.57%)
/settings/admin 246.67 KB 402.17 KB 114.91% (🟡 +0.25%)
/settings/admin/apps 258.93 KB 414.43 KB 118.41% (🟡 +0.26%)
/settings/admin/apps/[category] 258.89 KB 414.39 KB 118.40% (🟡 +0.26%)
/settings/admin/flags 250.22 KB 405.72 KB 115.92% (🟡 +0.26%)
/settings/admin/impersonation 246.94 KB 402.44 KB 114.98% (🟡 +0.26%)
/settings/admin/kycVerification 247.12 KB 402.62 KB 115.04% (🟡 +0.25%)
/settings/admin/organizations 247.94 KB 403.44 KB 115.27% (🟡 +0.26%)
/settings/admin/users 248.7 KB 404.2 KB 115.49% (🟡 +0.25%)
/settings/admin/users/[id]/edit 337.12 KB 492.62 KB 140.75% (🟡 +0.26%)
/settings/admin/users/add 336.85 KB 492.35 KB 140.67% (🟡 +0.26%)
/settings/billing 246.8 KB 402.3 KB 114.94% (🟡 +0.26%)
/settings/developer/api-keys 251.35 KB 406.85 KB 116.24% (🟡 +0.26%)
/settings/developer/webhooks 250.92 KB 406.42 KB 116.12% (🟡 +0.26%)
/settings/developer/webhooks/[id] 251.63 KB 407.13 KB 116.32% (🟡 +0.26%)
/settings/developer/webhooks/new 251.58 KB 407.09 KB 116.31% (🟡 +0.26%)
/settings/my-account/appearance 265.73 KB 421.24 KB 120.35% (🟡 +0.26%)
/settings/my-account/calendars 253.25 KB 408.75 KB 116.79% (🟡 +0.26%)
/settings/my-account/conferencing 252.75 KB 408.25 KB 116.64% (🟡 +0.26%)
/settings/my-account/general 334.03 KB 489.53 KB 139.87% (🟡 +0.26%)
/settings/my-account/profile 370.49 KB 526 KB 150.28% (🟡 +0.26%)
/settings/organizations/[id]/about 138.44 KB 293.95 KB 83.98% (🟡 +0.19%)
/settings/organizations/[id]/add-teams 138.48 KB 293.99 KB 84.00% (🟡 +0.18%)
/settings/organizations/[id]/onboard-admins 138.5 KB 294 KB 84.00% (🟡 +0.18%)
/settings/organizations/[id]/set-password 138.44 KB 293.94 KB 83.98% (🟡 +0.19%)
/settings/organizations/appearance 253.45 KB 408.95 KB 116.84% (🟡 +0.26%)
/settings/organizations/billing 246.64 KB 402.15 KB 114.90% (🟡 +0.26%)
/settings/organizations/general 326.66 KB 482.16 KB 137.76% (🟡 +0.26%)
/settings/organizations/members 362.1 KB 517.6 KB 147.89% (🟡 +0.26%)
/settings/organizations/new 138.45 KB 293.96 KB 83.99% (🟡 +0.18%)
/settings/organizations/profile 367.75 KB 523.26 KB 149.50% (🟡 +0.26%)
/settings/organizations/teams/other 247.74 KB 403.24 KB 115.21% (🟡 +0.26%)
/settings/organizations/teams/other/[id]/appearance 256.18 KB 411.69 KB 117.63% (🟡 +0.25%)
/settings/organizations/teams/other/[id]/members 250.41 KB 405.91 KB 115.97% (🟡 +0.26%)
/settings/organizations/teams/other/[id]/profile 438.26 KB 593.77 KB 169.65% (🟡 +0.30%)
/settings/security/impersonation 249.32 KB 404.83 KB 115.66% (🟡 +0.26%)
/settings/security/password 259.2 KB 414.7 KB 118.49% (🟡 +0.25%)
/settings/security/sso 255.61 KB 411.11 KB 117.46% (🟡 +0.26%)
/settings/security/two-factor-auth 252.66 KB 408.16 KB 116.62% (🟡 +0.26%)
/settings/teams 246.41 KB 401.91 KB 114.83% (🟡 +0.26%)
/settings/teams/[id]/appearance 256.17 KB 411.68 KB 117.62% (🟡 +0.26%)
/settings/teams/[id]/billing 246.65 KB 402.15 KB 114.90% (🟡 +0.26%)
/settings/teams/[id]/members 368.76 KB 524.26 KB 149.79% (🟡 +0.26%)
/settings/teams/[id]/onboard-members 148.89 KB 304.4 KB 86.97% (🟡 +0.14%)
/settings/teams/[id]/profile 438.64 KB 594.14 KB 169.75% (🟡 +0.31%)
/settings/teams/[id]/sso 255.71 KB 411.22 KB 117.49% (🟡 +0.26%)
/settings/teams/new 185.26 KB 340.77 KB 97.36% (🟡 +0.18%)
/team/[slug]/[type] 225.64 KB 381.15 KB 108.90% (🟡 +0.57%)
/team/[slug]/[type]/embed 225.68 KB 381.18 KB 108.91% (🟡 +0.57%)
/teams 240.52 KB 396.02 KB 113.15% (🟡 +0.26%)
/workflows 277.07 KB 432.57 KB 123.59% (🟡 +0.26%)
/workflows/[workflow] 388.01 KB 543.51 KB 155.29% (🟡 +0.26%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar Aug 18 '23 16:08 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 28 '23 09:08 CLAassistant

Hey there, there is a merge conflict, can you take a look?

github-actions[bot] avatar Sep 28 '23 11:09 github-actions[bot]

Closing it for now as it's low priority

hariombalhara avatar Oct 06 '23 05:10 hariombalhara