#8701 CAL-1621 new booker dialog grow in height

[sean-brydon]

What does this PR do?

Grows in height with content more than it used to.

Auto scrolls when an error is present

[linear[bot]]

CAL-1621 Grow Dialog in Height

scrolling is not clear and we have the space

CleanShot 2023-05-05 at 15.04.412x.jpg

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 3:51pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2023 3:51pm

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (350 KB)
/apps/[slug]/[...pages]	456.42 KB	607.35 KB	173.53% (🟢 -0.16%)
/auth/setup	174.24 KB	325.17 KB	92.91% (🟢 -0.15%)
/event-types/[type]	468.25 KB	619.18 KB	176.91% (🟢 -0.19%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

[ciaranha]

@sean-brydon looks great 👏 Can you just double-check the spacing above and below the modal title? Also, in designs I have the title font-size at 20px.

[deploysentinel[bot]]

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/11/2023 04:21:12pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: de1cbf107328d4f0b2a99043869890d10cdb427d

Started: 05/11/2023 04:11:59pm UTC

⚠️ Flakes

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted Retry 1 • Initial Attempt	0% (0) 0 / 335 runs failed over last 7 days	39.40% (132) 132 / 335 runs flaked over last 7 days

---

View Detailed Build Results

---

[JeroenReumkens]

LGTM — merged!