cal.com icon indicating copy to clipboard operation
cal.com copied to clipboard

CAL-1623 CAL-1620: Improve animation for booker, and push mini calendar down in fullscreen views

Open JeroenReumkens opened this issue 1 year ago • 4 comments

What does this PR do?

  • Adds height animation for new booker
  • moves animation to custom hook using useAnimate to clean up booker code a bit
  • Push mini calendar down in fullscreen views

Fixes CAL-1623 CAL-1620

https://user-images.githubusercontent.com/2969573/237053861-14ce35b7-72d1-4f1c-b0cf-02577adbe6a4.mp4

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • [ ] Test the 3 booker layouts as well as mobile, verify that layouts + animations look good.

JeroenReumkens avatar May 09 '23 09:05 JeroenReumkens

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 3:11pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 3:11pm

vercel[bot] avatar May 09 '23 09:05 vercel[bot]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Four Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 456.73 KB 607.55 KB 173.59% (🟡 +0.17%)
/auth/setup 174.65 KB 325.46 KB 92.99% (🟡 +0.16%)
/new-booker/[user]/[type] 286.35 KB 437.17 KB 124.90% (🟡 +0.89%)
/new-booker/team/[slug]/[type] 286.35 KB 437.17 KB 124.91% (🟡 +0.88%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/-

github-actions[bot] avatar May 09 '23 09:05 github-actions[bot]

Current Playwright Test Results Summary

✅ 98 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/09/2023 03:26:35pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 165d36e266bd2bb2dcccda65fce35b51d9158f32

Started: 05/09/2023 03:16:29pm UTC

⚠️ Flakes

📄   apps/web/playwright/embed-code-generator.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Embed Code Generator Tests Event Type Edit Page open Embed Dialog for the Event Type
Retry 1Initial Attempt
4.87% (13) 13 / 267 runs
failed over last 7 days
22.47% (60) 60 / 267 runs
flaked over last 7 days

📄   apps/web/playwright/booking-seats.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Booking with Seats -- new-booker Reschedule for booking with seats -- old-booker Should reschedule booking with seats and if everyone rescheduled it should be deleted
Retry 1Initial Attempt
0% (0) 0 / 276 runs
failed over last 7 days
4.71% (13) 13 / 276 runs
flaked over last 7 days

📄   apps/web/playwright/app-store.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
App Store - Authed Browse apple-calendar and try to install
Retry 1Initial Attempt
0.35% (1) 1 / 286 run
failed over last 7 days
64.34% (184) 184 / 286 runs
flaked over last 7 days

View Detailed Build Results


deploysentinel[bot] avatar May 09 '23 10:05 deploysentinel[bot]